From ca913b05498bf0ba1cd4318d968069a629858714 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 26 Jan 2018 15:11:40 +0100 Subject: [PATCH] Stop using public_deps in modules/audio_processing/aec_dump. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:8603 Change-Id: I8d21a195323bfa088003d47a67f41a387d0101fa Reviewed-on: https://webrtc-review.googlesource.com/34186 Commit-Queue: Mirko Bonadei Reviewed-by: Patrik Höglund Cr-Commit-Position: refs/heads/master@{#21791} --- media/BUILD.gn | 1 + modules/audio_processing/aec_dump/BUILD.gn | 17 ++++------------- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/media/BUILD.gn b/media/BUILD.gn index a1a00fc7bd..09685f997f 100644 --- a/media/BUILD.gn +++ b/media/BUILD.gn @@ -232,6 +232,7 @@ rtc_static_library("rtc_audio_video") { defines = [] libs = [] deps = [ + "../modules/audio_processing/aec_dump:aec_dump", "../modules/video_coding:video_codec_interface", "../modules/video_coding:video_coding", "../rtc_base:checks", diff --git a/modules/audio_processing/aec_dump/BUILD.gn b/modules/audio_processing/aec_dump/BUILD.gn index cd78a59dcd..b6a9dd34ab 100644 --- a/modules/audio_processing/aec_dump/BUILD.gn +++ b/modules/audio_processing/aec_dump/BUILD.gn @@ -14,11 +14,8 @@ rtc_source_set("aec_dump") { "aec_dump_factory.h", ] - public_deps = [ - "..:aec_dump_interface", - ] - deps = [ + "..:aec_dump_interface", "../../../rtc_base:rtc_base_approved", ] } @@ -32,8 +29,6 @@ rtc_source_set("mock_aec_dump") { deps = [ "..:aec_dump_interface", - ] - public_deps = [ "../..:module_api", "../../../test:test_support", ] @@ -65,14 +60,9 @@ if (rtc_enable_protobuf) { "write_to_file_task.h", ] - public = [] - - public_deps = [ + deps = [ ":aec_dump", "..:aec_dump_interface", - ] - - deps = [ "../../../modules:module_api", "../../../rtc_base:checks", "../../../rtc_base:protobuf_utils", @@ -88,6 +78,7 @@ if (rtc_enable_protobuf) { testonly = true defines = [] deps = [ + ":aec_dump", ":aec_dump_impl", "..:aec_dump_interface", "..:audioproc_debug_proto", @@ -108,7 +99,7 @@ rtc_source_set("null_aec_dump_factory") { "null_aec_dump_factory.cc", ] - public_deps = [ + deps = [ ":aec_dump", "..:aec_dump_interface", ]