From ca3c8017e5fc272e6320d2de47befb3915c2297e Mon Sep 17 00:00:00 2001 From: Konrad Hofbauer Date: Fri, 15 Feb 2019 20:52:19 +0100 Subject: [PATCH] Minor eventlogvisualizer tweaks. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Clarify sequence number plot. - Add pacer_delay plot to plot profile 'all'. Bug: none Change-Id: Ib009481cfd8858bee556d5d28610bc0c65a6859c Reviewed-on: https://webrtc-review.googlesource.com/c/123101 Commit-Queue: Konrad Hofbauer Reviewed-by: Björn Terelius Cr-Commit-Position: refs/heads/master@{#26720} --- rtc_tools/event_log_visualizer/analyzer.cc | 5 +++-- rtc_tools/event_log_visualizer/main.cc | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/rtc_tools/event_log_visualizer/analyzer.cc b/rtc_tools/event_log_visualizer/analyzer.cc index a4126bc921..b8eff1d9a3 100644 --- a/rtc_tools/event_log_visualizer/analyzer.cc +++ b/rtc_tools/event_log_visualizer/analyzer.cc @@ -667,7 +667,8 @@ void EventLogAnalyzer::CreateAudioLevelGraph(PacketDirection direction, plot->SetTitle(GetDirectionAsString(direction) + " audio level"); } -// For each SSRC, plot the time between the consecutive playouts. +// For each SSRC, plot the sequence number difference between consecutive +// incoming packets. void EventLogAnalyzer::CreateSequenceNumberGraph(Plot* plot) { for (const auto& stream : parsed_log_.incoming_rtp_packets_by_ssrc()) { // Filter on SSRC. @@ -697,7 +698,7 @@ void EventLogAnalyzer::CreateSequenceNumberGraph(Plot* plot) { "Time (s)", kLeftMargin, kRightMargin); plot->SetSuggestedYAxis(0, 1, "Difference since last packet", kBottomMargin, kTopMargin); - plot->SetTitle("Sequence number"); + plot->SetTitle("Incoming sequence number delta"); } void EventLogAnalyzer::CreateIncomingPacketLossGraph(Plot* plot) { diff --git a/rtc_tools/event_log_visualizer/main.cc b/rtc_tools/event_log_visualizer/main.cc index 11824da5df..252f630b3f 100644 --- a/rtc_tools/event_log_visualizer/main.cc +++ b/rtc_tools/event_log_visualizer/main.cc @@ -555,4 +555,5 @@ void SetAllPlotFlags(bool setting) { FLAG_plot_neteq_stats = setting; FLAG_plot_ice_candidate_pair_config = setting; FLAG_plot_ice_connectivity_check = setting; + FLAG_plot_pacer_delay = setting; }