admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Comment unused variables in implemented functions 4\n

Browse Source 
Bug: webrtc:370878648
Change-Id: I32d472174ce4f9f31b829ea89a82a003d333d2b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364539
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#43279}
This commit is contained in:
Dor Hen 2024-10-22 02:41:05 -07:00 committed by WebRTC LUCI CQ
parent 6d58a43413
commit ca07d54192
14 changed files with 52 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
api/audio_codecs/audio_decoder.cc
View File

@ -130,7 +130,8 @@ bool AudioDecoder::HasDecodePlc() const {
return false; return false;
} }
size_t AudioDecoder::DecodePlc(size_t num_frames, int16_t* decoded) { size_t AudioDecoder::DecodePlc(size_t /* num_frames */,
int16_t* /* decoded */) {
return 0; return 0;
} }
@ -142,18 +143,18 @@ int AudioDecoder::ErrorCode() {
return 0; return 0;
} }
int AudioDecoder::PacketDuration(const uint8_t* encoded, int AudioDecoder::PacketDuration(const uint8_t* /* encoded */,
size_t encoded_len) const { size_t /* encoded_len */) const {
return kNotImplemented; return kNotImplemented;
} }
int AudioDecoder::PacketDurationRedundant(const uint8_t* encoded, int AudioDecoder::PacketDurationRedundant(const uint8_t* /* encoded */,
size_t encoded_len) const { size_t /* encoded_len */) const {
return kNotImplemented; return kNotImplemented;
} }
bool AudioDecoder::PacketHasFec(const uint8_t* encoded, bool AudioDecoder::PacketHasFec(const uint8_t* /* encoded */,
size_t encoded_len) const { size_t /* encoded_len */) const {
return false; return false;
} }

27
api/audio_codecs/audio_encoder.cc
View File

@ -67,31 +67,32 @@ bool AudioEncoder::GetDtx() const {
return false; return false;
} }
bool AudioEncoder::SetApplication(Application application) { bool AudioEncoder::SetApplication(Application /* application */) {
return false; return false;
} }
void AudioEncoder::SetMaxPlaybackRate(int frequency_hz) {} void AudioEncoder::SetMaxPlaybackRate(int /* frequency_hz */) {}
void AudioEncoder::SetTargetBitrate(int target_bps) {} void AudioEncoder::SetTargetBitrate(int /* target_bps */) {}
rtc::ArrayView<std::unique_ptr<AudioEncoder>> rtc::ArrayView<std::unique_ptr<AudioEncoder>>
AudioEncoder::ReclaimContainedEncoders() { AudioEncoder::ReclaimContainedEncoders() {
return nullptr; return nullptr;
} }
bool AudioEncoder::EnableAudioNetworkAdaptor(const std::string& config_string, bool AudioEncoder::EnableAudioNetworkAdaptor(
RtcEventLog* event_log) { const std::string& /* config_string */,
RtcEventLog* /* event_log */) {
return false; return false;
} }
void AudioEncoder::DisableAudioNetworkAdaptor() {} void AudioEncoder::DisableAudioNetworkAdaptor() {}
void AudioEncoder::OnReceivedUplinkPacketLossFraction( void AudioEncoder::OnReceivedUplinkPacketLossFraction(
float uplink_packet_loss_fraction) {} float /* uplink_packet_loss_fraction */) {}
void AudioEncoder::OnReceivedUplinkRecoverablePacketLossFraction( void AudioEncoder::OnReceivedUplinkRecoverablePacketLossFraction(
float uplink_recoverable_packet_loss_fraction) { float /* uplink_recoverable_packet_loss_fraction */) {
RTC_DCHECK_NOTREACHED(); RTC_DCHECK_NOTREACHED();
} }
@ -100,20 +101,20 @@ void AudioEncoder::OnReceivedTargetAudioBitrate(int target_audio_bitrate_bps) {
} }
void AudioEncoder::OnReceivedUplinkBandwidth( void AudioEncoder::OnReceivedUplinkBandwidth(
int target_audio_bitrate_bps, int /* target_audio_bitrate_bps */,
std::optional<int64_t> bwe_period_ms) {} std::optional<int64_t> /* bwe_period_ms */) {}
void AudioEncoder::OnReceivedUplinkAllocation(BitrateAllocationUpdate update) { void AudioEncoder::OnReceivedUplinkAllocation(BitrateAllocationUpdate update) {
OnReceivedUplinkBandwidth(update.target_bitrate.bps(), OnReceivedUplinkBandwidth(update.target_bitrate.bps(),
update.bwe_period.ms()); update.bwe_period.ms());
} }
void AudioEncoder::OnReceivedRtt(int rtt_ms) {} void AudioEncoder::OnReceivedRtt(int /* rtt_ms */) {}
void AudioEncoder::OnReceivedOverhead(size_t overhead_bytes_per_packet) {} void AudioEncoder::OnReceivedOverhead(size_t /* overhead_bytes_per_packet */) {}
void AudioEncoder::SetReceiverFrameLengthRange(int min_frame_length_ms, void AudioEncoder::SetReceiverFrameLengthRange(int /* min_frame_length_ms */,
int max_frame_length_ms) {} int /* max_frame_length_ms */) {}
ANAStats AudioEncoder::GetANAStats() const { ANAStats AudioEncoder::GetANAStats() const {
return ANAStats(); return ANAStats();

2
api/media_stream_interface.cc
View File

@ -25,7 +25,7 @@ VideoTrackInterface::ContentHint VideoTrackInterface::content_hint() const {
return ContentHint::kNone; return ContentHint::kNone;
} }
bool AudioTrackInterface::GetSignalLevel(int* level) { bool AudioTrackInterface::GetSignalLevel(int* /* level */) {
return false; return false;
} }

5
api/rtp_sender_interface.cc
View File

@ -15,8 +15,9 @@
namespace webrtc { namespace webrtc {
void RtpSenderInterface::SetParametersAsync(const RtpParameters& parameters, void RtpSenderInterface::SetParametersAsync(
SetParametersCallback callback) { const RtpParameters& /* parameters */,
SetParametersCallback /* callback */) {
RTC_DCHECK_NOTREACHED() << "Default implementation called"; RTC_DCHECK_NOTREACHED() << "Default implementation called";
} }

2
api/video/video_bitrate_allocator.cc
View File

@ -54,6 +54,6 @@ VideoBitrateAllocation VideoBitrateAllocator::Allocate(
return GetAllocation(parameters.total_bitrate.bps(), parameters.framerate); return GetAllocation(parameters.total_bitrate.bps(), parameters.framerate);
} }
void VideoBitrateAllocator::SetLegacyConferenceMode(bool enabled) {} void VideoBitrateAllocator::SetLegacyConferenceMode(bool /* enabled */) {}
} // namespace webrtc } // namespace webrtc

2
api/video/video_frame_buffer.cc
View File

@ -78,7 +78,7 @@ const NV12BufferInterface* VideoFrameBuffer::GetNV12() const {
} }
rtc::scoped_refptr<VideoFrameBuffer> VideoFrameBuffer::GetMappedFrameBuffer( rtc::scoped_refptr<VideoFrameBuffer> VideoFrameBuffer::GetMappedFrameBuffer(
rtc::ArrayView<Type> types) { rtc::ArrayView<Type> /* types */) {
RTC_CHECK(type() == Type::kNative); RTC_CHECK(type() == Type::kNative);
return nullptr; return nullptr;
} }

4
api/video_codecs/video_decoder.cc
View File

@ -21,14 +21,14 @@
namespace webrtc { namespace webrtc {
int32_t DecodedImageCallback::Decoded(VideoFrame& decodedImage, int32_t DecodedImageCallback::Decoded(VideoFrame& decodedImage,
int64_t decode_time_ms) { int64_t /* decode_time_ms */) {
// The default implementation ignores custom decode time value. // The default implementation ignores custom decode time value.
return Decoded(decodedImage); return Decoded(decodedImage);
} }
void DecodedImageCallback::Decoded(VideoFrame& decodedImage, void DecodedImageCallback::Decoded(VideoFrame& decodedImage,
std::optional<int32_t> decode_time_ms, std::optional<int32_t> decode_time_ms,
std::optional<uint8_t> qp) { std::optional<uint8_t> /* qp */) {
Decoded(decodedImage, decode_time_ms.value_or(-1)); Decoded(decodedImage, decode_time_ms.value_or(-1));
} }

8
api/video_codecs/video_encoder.cc
View File

@ -310,7 +310,7 @@ bool VideoEncoder::RateControlParameters::operator!=(
VideoEncoder::RateControlParameters::~RateControlParameters() = default; VideoEncoder::RateControlParameters::~RateControlParameters() = default;
void VideoEncoder::SetFecControllerOverride( void VideoEncoder::SetFecControllerOverride(
FecControllerOverride* fec_controller_override) {} FecControllerOverride* /* fec_controller_override */) {}
int32_t VideoEncoder::InitEncode(const VideoCodec* codec_settings, int32_t VideoEncoder::InitEncode(const VideoCodec* codec_settings,
int32_t number_of_cores, int32_t number_of_cores,
@ -335,11 +335,11 @@ int VideoEncoder::InitEncode(const VideoCodec* codec_settings,
settings.max_payload_size); settings.max_payload_size);
} }
void VideoEncoder::OnPacketLossRateUpdate(float packet_loss_rate) {} void VideoEncoder::OnPacketLossRateUpdate(float /* packet_loss_rate */) {}
void VideoEncoder::OnRttUpdate(int64_t rtt_ms) {} void VideoEncoder::OnRttUpdate(int64_t /* rtt_ms */) {}
void VideoEncoder::OnLossNotification( void VideoEncoder::OnLossNotification(
const LossNotification& loss_notification) {} const LossNotification& /* loss_notification */) {}
} // namespace webrtc } // namespace webrtc

2
common_audio/resampler/push_sinc_resampler.cc
View File

@ -33,7 +33,7 @@ PushSincResampler::~PushSincResampler() {}
size_t PushSincResampler::Resample(const int16_t* source, size_t PushSincResampler::Resample(const int16_t* source,
size_t source_length, size_t source_length,
int16_t* destination, int16_t* destination,
size_t destination_capacity) { size_t /* destination_capacity */) {
if (!float_buffer_.get()) if (!float_buffer_.get())
float_buffer_.reset(new float[destination_frames_]); float_buffer_.reset(new float[destination_frames_]);

2
common_audio/third_party/ooura/fft_size_128/ooura_fft.cc vendored
View File

@ -313,7 +313,7 @@ static void rftbsub_128_C(float* a) {
} // namespace } // namespace
OouraFft::OouraFft(bool sse2_available) { OouraFft::OouraFft([[maybe_unused]] bool sse2_available) {
#if defined(WEBRTC_ARCH_X86_FAMILY) #if defined(WEBRTC_ARCH_X86_FAMILY)
use_sse2_ = sse2_available; use_sse2_ = sse2_available;
#else #else

8
logging/rtc_event_log/events/rtc_event_ice_candidate_pair.h
View File

@ -73,15 +73,15 @@ class RtcEventIceCandidatePair final : public RtcEvent {
uint32_t candidate_pair_id() const { return candidate_pair_id_; } uint32_t candidate_pair_id() const { return candidate_pair_id_; }
uint32_t transaction_id() const { return transaction_id_; } uint32_t transaction_id() const { return transaction_id_; }
static std::string Encode(rtc::ArrayView<const RtcEvent*> batch) { static std::string Encode(rtc::ArrayView<const RtcEvent*> /* batch */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return ""; return "";
} }
static RtcEventLogParseStatus Parse( static RtcEventLogParseStatus Parse(
absl::string_view encoded_bytes, absl::string_view /* encoded_bytes */,
bool batched, bool /* batched */,
std::vector<LoggedIceCandidatePairEvent>& output) { std::vector<LoggedIceCandidatePairEvent>& /* output */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__); return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__);
} }

8
logging/rtc_event_log/events/rtc_event_ice_candidate_pair_config.h
View File

@ -118,15 +118,15 @@ class RtcEventIceCandidatePairConfig final : public RtcEvent {
return candidate_pair_desc_; return candidate_pair_desc_;
} }
static std::string Encode(rtc::ArrayView<const RtcEvent*> batch) { static std::string Encode(rtc::ArrayView<const RtcEvent*> /* batch */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return ""; return "";
} }
static RtcEventLogParseStatus Parse( static RtcEventLogParseStatus Parse(
absl::string_view encoded_bytes, absl::string_view /* encoded_bytes */,
bool batched, bool /* batched */,
std::vector<LoggedIceCandidatePairConfig>& output) { std::vector<LoggedIceCandidatePairConfig>& /* output */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__); return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__);
} }

8
logging/rtc_event_log/events/rtc_event_rtcp_packet_incoming.h
View File

@ -40,15 +40,15 @@ class RtcEventRtcpPacketIncoming final : public RtcEvent {
const rtc::Buffer& packet() const { return packet_; } const rtc::Buffer& packet() const { return packet_; }
static std::string Encode(rtc::ArrayView<const RtcEvent*> batch) { static std::string Encode(rtc::ArrayView<const RtcEvent*> /* batch */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return ""; return "";
} }
static RtcEventLogParseStatus Parse( static RtcEventLogParseStatus Parse(
absl::string_view encoded_bytes, absl::string_view /* encoded_bytes */,
bool batched, bool /* batched */,
std::vector<LoggedRtcpPacketIncoming>& output) { std::vector<LoggedRtcpPacketIncoming>& /* output */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__); return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__);
} }

8
logging/rtc_event_log/events/rtc_event_rtcp_packet_outgoing.h
View File

@ -40,15 +40,15 @@ class RtcEventRtcpPacketOutgoing final : public RtcEvent {
const rtc::Buffer& packet() const { return packet_; } const rtc::Buffer& packet() const { return packet_; }
static std::string Encode(rtc::ArrayView<const RtcEvent*> batch) { static std::string Encode(rtc::ArrayView<const RtcEvent*> /* batch */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return ""; return "";
} }
static RtcEventLogParseStatus Parse( static RtcEventLogParseStatus Parse(
absl::string_view encoded_bytes, absl::string_view /* encoded_bytes */,
bool batched, bool /* batched */,
std::vector<LoggedRtcpPacketOutgoing>& output) { std::vector<LoggedRtcpPacketOutgoing>& /* output */) {
// TODO(terelius): Implement // TODO(terelius): Implement
return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__); return RtcEventLogParseStatus::Error("Not Implemented", __FILE__, __LINE__);
} }