admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ssl_certificate() accessor.

Browse Source 
The Cl landing the alternative was dated 2018, and an (informal)
deprecation notice was landed. The users are now gone.

Bug: None
Change-Id: I1f49143fe5f2c236bf9574469f2573593b7a8086
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/223663
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Philipp Hancke <phancke@nvidia.com>
Cr-Commit-Position: refs/heads/master@{#34365}
This commit is contained in:
Harald Alvestrand 2021-06-24 13:02:09 +00:00 committed by WebRTC LUCI CQ
parent e9a74c918b
commit c830bd627f
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rtc_base/rtc_certificate.cc
View File

@ -46,11 +46,6 @@ const SSLCertificate& RTCCertificate::GetSSLCertificate() const {
return identity_->certificate(); return identity_->certificate();
} }
// Deprecated: TODO(benwright) - Remove once chromium is updated.
const SSLCertificate& RTCCertificate::ssl_certificate() const {
return identity_->certificate();
}
const SSLCertChain& RTCCertificate::GetSSLCertificateChain() const { const SSLCertChain& RTCCertificate::GetSSLCertificateChain() const {
return identity_->cert_chain(); return identity_->cert_chain();
} }

4
rtc_base/rtc_certificate.h
View File

@ -16,6 +16,7 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include "absl/base/attributes.h"
#include "api/ref_counted_base.h" #include "api/ref_counted_base.h"
#include "api/scoped_refptr.h" #include "api/scoped_refptr.h"
#include "rtc_base/system/rtc_export.h" #include "rtc_base/system/rtc_export.h"
@ -65,9 +66,6 @@ class RTC_EXPORT RTCCertificate final
const SSLCertificate& GetSSLCertificate() const; const SSLCertificate& GetSSLCertificate() const;
const SSLCertChain& GetSSLCertificateChain() const; const SSLCertChain& GetSSLCertificateChain() const;
// Deprecated: TODO(benwright) - Remove once chromium is updated.
const SSLCertificate& ssl_certificate() const;
// TODO(hbos): If possible, remove once RTCCertificate and its // TODO(hbos): If possible, remove once RTCCertificate and its
// GetSSLCertificate() is used in all relevant places. Should not pass around // GetSSLCertificate() is used in all relevant places. Should not pass around
// raw SSLIdentity* for the sake of accessing SSLIdentity::certificate(). // raw SSLIdentity* for the sake of accessing SSLIdentity::certificate().