admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Disable failing modules_unittests for UBSan. (patchset #1 id:40001 of https://codereview.webrtc.org/1915813002/ )

Browse Source 
Reason for revert:
Fix upstream should've landed in our repository.

Original issue's description:
> Disable failing modules_unittests for UBSan.
>
> BUG=webrtc:5820
> TBR=pbos@webrtc.org
>
> Committed: https://crrev.com/c23bf2e54d922486254cdd7657aafceaa958ce25
> Cr-Commit-Position: refs/heads/master@{#12482}

TBR=kjellander@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5820

Review-Url: https://codereview.webrtc.org/1937153002
Cr-Commit-Position: refs/heads/master@{#12647}
This commit is contained in:
pbos 2016-05-06 12:50:04 -07:00 committed by Commit bot
parent 82d7862fe7
commit c7a6569713
3 changed files with 6 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/audio_coding/neteq/neteq_unittest.cc
View File

@ -446,11 +446,10 @@ void NetEqDecodingTest::PopulateCng(int frame_index,
*payload_len = 1; // Only noise level, no spectral parameters.
}
// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
#if !defined(WEBRTC_IOS) && defined(WEBRTC_NETEQ_UNITTEST_BITEXACT) && \
(defined(WEBRTC_CODEC_ISAC) || defined(WEBRTC_CODEC_ISACFX)) && \
defined(WEBRTC_CODEC_ILBC) && defined(WEBRTC_CODEC_G722) && \
!defined(WEBRTC_ARCH_ARM64) && !defined(UNDEFINED_SANITIZER)
!defined(WEBRTC_ARCH_ARM64)
#define MAYBE_TestBitExactness TestBitExactness
#else
#define MAYBE_TestBitExactness DISABLED_TestBitExactness
@ -484,10 +483,9 @@ TEST_F(NetEqDecodingTest, MAYBE_TestBitExactness) {
FLAGS_gen_ref);
}
// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
#if !defined(WEBRTC_IOS) && !defined(WEBRTC_ANDROID) && \
defined(WEBRTC_NETEQ_UNITTEST_BITEXACT) && \
defined(WEBRTC_CODEC_OPUS) && !defined(UNDEFINED_SANITIZER)
defined(WEBRTC_CODEC_OPUS)
#define MAYBE_TestOpusBitExactness TestOpusBitExactness
#else
#define MAYBE_TestOpusBitExactness DISABLED_TestOpusBitExactness

32
webrtc/modules/audio_processing/audio_processing_unittest.cc
View File

@ -1847,35 +1847,17 @@ void ApmTest::VerifyDebugDumpTest(Format format) {
remove(limited_filename.c_str());
}
// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
#ifdef UNDEFINED_SANITIZER
#define MAYBE_VerifyDebugDumpInt DISABLED_VerifyDebugDumpInt
#else
#define MAYBE_VerifyDebugDumpInt VerifyDebugDumpInt
#endif
TEST_F(ApmTest, MAYBE_VerifyDebugDumpInt) {
TEST_F(ApmTest, VerifyDebugDumpInt) {
VerifyDebugDumpTest(kIntFormat);
}
// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
#ifdef UNDEFINED_SANITIZER
#define MAYBE_VerifyDebugDumpFloat DISABLED_VerifyDebugDumpFloat
#else
#define MAYBE_VerifyDebugDumpFloat VerifyDebugDumpFloat
#endif
TEST_F(ApmTest, MAYBE_VerifyDebugDumpFloat) {
TEST_F(ApmTest, VerifyDebugDumpFloat) {
VerifyDebugDumpTest(kFloatFormat);
}
#endif
// TODO(andrew): expand test to verify output.
// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
#ifdef UNDEFINED_SANITIZER
#define MAYBE_DebugDump DISABLED_DebugDump
#else
#define MAYBE_DebugDump DebugDump
#endif
TEST_F(ApmTest, MAYBE_DebugDump) {
TEST_F(ApmTest, DebugDump) {
const std::string filename =
test::TempFilename(test::OutputPath(), "debug_aec");
EXPECT_EQ(apm_->kNullPointerError,
@ -1908,13 +1890,7 @@ TEST_F(ApmTest, MAYBE_DebugDump) {
}
// TODO(andrew): expand test to verify output.
// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
#ifdef UNDEFINED_SANITIZER
#define MAYBE_DebugDumpFromFileHandle DISABLED_DebugDumpFromFileHandle
#else
#define MAYBE_DebugDumpFromFileHandle DebugDumpFromFileHandle
#endif
TEST_F(ApmTest, MAYBE_DebugDumpFromFileHandle) {
TEST_F(ApmTest, DebugDumpFromFileHandle) {
FILE* fid = NULL;
EXPECT_EQ(apm_->kNullPointerError, apm_->StartDebugRecording(fid, -1));
const std::string filename =

4
webrtc/modules/audio_processing/test/debug_dump_test.cc
View File

@ -263,8 +263,6 @@ void DebugDumpTest::VerifyDebugDump(const std::string& in_filename) {
}
}
// Disabled for UBSan: https://bugs.chromium.org/p/webrtc/issues/detail?id=5820
#ifndef UNDEFINED_SANITIZER
TEST_F(DebugDumpTest, SimpleCase) {
Config config;
DebugDumpGenerator generator(config);
@ -528,7 +526,5 @@ TEST_F(DebugDumpTest, TransientSuppressionOn) {
VerifyDebugDump(generator.dump_file_name());
}
#endif // !UNDEFINED_SANITIZER
} // namespace test
} // namespace webrtc