admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing -Wno-comment.

Browse Source 
Chromium is suppressing this warning only on GCC [1], so WebRTC should
not suppress it on clang and just rely on Chromium's defaults.

[1] - https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?l=1356&rcl=027d7fa1c191f60f754985b9c235597f8c9a2081

Bug: webrtc:9251
Change-Id: I9316cbdda4083da7d859ff0b9c60579546ddbfcb
Reviewed-on: https://webrtc-review.googlesource.com/75301
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23183}
This commit is contained in:
Mirko Bonadei 2018-05-08 16:52:55 +02:00 committed by Commit Bot
parent f4e8b9f511
commit c710ac142e
3 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/video_capture/BUILD.gn
View File

@ -81,7 +81,6 @@ if (!build_with_chromium) {
config("video_capture_internal_impl_warnings_config") {
if (is_win && is_clang) {
cflags = [
"-Wno-comment",
"-Wno-ignored-attributes",
# See https://bugs.chromium.org/p/webrtc/issues/detail?id=6269

13
modules/video_capture/windows/device_info_ds.cc
View File

@ -539,13 +539,12 @@ int32_t DeviceInfoDS::CreateCapabilityMap(const char* deviceUniqueIdUTF8)
return static_cast<int32_t>(_captureCapabilities.size());
}
/* Constructs a product ID from the Windows DevicePath. on a USB device the
devicePath contains product id and vendor id. This seems to work for firewire
as well
/* Example of device path
"\\?\usb#vid_0408&pid_2010&mi_00#7&258e7aaf&0&0000#{65e8773d-8f56-11d0-a3b9-00a0c9223196}\global"
"\\?\avc#sony&dv-vcr&camcorder&dv#65b2d50301460008#{65e8773d-8f56-11d0-a3b9-00a0c9223196}\global"
*/
// Constructs a product ID from the Windows DevicePath. on a USB device the
// devicePath contains product id and vendor id. This seems to work for firewire
// as well.
// Example of device path:
// "\\?\usb#vid_0408&pid_2010&mi_00#7&258e7aaf&0&0000#{65e8773d-8f56-11d0-a3b9-00a0c9223196}\global"
// "\\?\avc#sony&dv-vcr&camcorder&dv#65b2d50301460008#{65e8773d-8f56-11d0-a3b9-00a0c9223196}\global"
void DeviceInfoDS::GetProductId(const char* devicePath,
char* productUniqueIdUTF8,
uint32_t productUniqueIdUTF8Length) {

1
test/BUILD.gn
View File

@ -604,7 +604,6 @@ config("test_renderer_exported_config") {
# come from a config and cannot be on the target directly.
cflags = [
"-Wno-bool-conversion",
"-Wno-comment",
"-Wno-delete-non-virtual-dtor",
]
}