From c6d3a7a69148ddb5a54f41265deaff84d4801b8d Mon Sep 17 00:00:00 2001 From: Per Kjellander Date: Thu, 24 Feb 2022 17:32:12 +0100 Subject: [PATCH] Ensure returned delay based estimate from probe can be clamped by AimdRateControl AimdRateControl can potentially clamp bitrate in SetEstimate. DelayBasedBwe::MaybeUpdateEstimate should therefore check the result before using the probe bitrate. Otherwise, BWE may drop on next update. Bug: none Change-Id: I8b1b3549a2bcd981e941b1cc802c984828d68261 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252444 Reviewed-by: Stefan Holmer Commit-Queue: Per Kjellander Cr-Commit-Position: refs/heads/main@{#36099} --- modules/congestion_controller/goog_cc/delay_based_bwe.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/congestion_controller/goog_cc/delay_based_bwe.cc b/modules/congestion_controller/goog_cc/delay_based_bwe.cc index 2ae5441ef4..01dfbc44e4 100644 --- a/modules/congestion_controller/goog_cc/delay_based_bwe.cc +++ b/modules/congestion_controller/goog_cc/delay_based_bwe.cc @@ -243,8 +243,8 @@ DelayBasedBwe::Result DelayBasedBwe::MaybeUpdateEstimate( if (probe_bitrate) { result.probe = true; result.updated = true; - result.target_bitrate = *probe_bitrate; rate_control_.SetEstimate(*probe_bitrate, at_time); + result.target_bitrate = rate_control_.LatestEstimate(); } else { result.updated = UpdateEstimate(at_time, acked_bitrate, &result.target_bitrate);