From c68d046bb10f136c7ec252ff92a0b6a0a8302cc1 Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Mon, 10 Feb 2014 21:28:55 +0000 Subject: [PATCH] Fix BUILD.gn to load all Chromium GN configurations. After troubleshooting with brettw@chromium.org we found that this line is needed in order to get the build/config/BUILD.gn configurations loaded. This should solve the runhooks failures in http://build.chromium.org/p/client.webrtc.fyi/waterfall and make it possible to generate projects with GYP_DEFINES="disable_glibcxx_debug=1" (which fails today). TEST=Ran on Linux: GYP_DEFINES=build_with_tool=tsan gclient runhooks without and with this patch applied (it fails without). R=andrew@webrtc.org, brettw@chromium.org Review URL: https://webrtc-codereview.appspot.com/8379004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5521 4adac7df-926f-26a2-2b94-8c16560cd09d --- BUILD.gn | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BUILD.gn b/BUILD.gn index 57cfab628c..12ad5ff4cb 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -7,10 +7,17 @@ # be found in the AUTHORS file in the root of the source tree. # This file is copied and modified from Chromium (src/BUILD.gn). - group("root") { external = true deps = [ ] } + +# A standard (non-group) target is required in the build to load any of the +# configurations, which is in turn required to load all of the build parameters +# (in build/config/BUILD.gn). +executable("dummy") { + external = true +} +