From c61d53584b6501052d7f7d479d426de6baa87b2d Mon Sep 17 00:00:00 2001 From: Florent Castelli Date: Mon, 27 Jun 2022 19:59:39 +0200 Subject: [PATCH] Add a descriptive name to parametrized E2E tests This changes names from "SvcTestVP9/SvcTest.ScalabilityModeSupported/11" to "SvcTestVP9/SvcTest.ScalabilityModeSupported/L3T3" Bug: webrtc:11607 Change-Id: I1425f7541e1ea7533dff06be9ef9926e5ace3f70 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267005 Commit-Queue: Harald Alvestrand Reviewed-by: Harald Alvestrand Auto-Submit: Florent Castelli Cr-Commit-Position: refs/heads/main@{#37343} --- pc/test/svc_e2e_tests.cc | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/pc/test/svc_e2e_tests.cc b/pc/test/svc_e2e_tests.cc index e5595431bc..30a0ca4475 100644 --- a/pc/test/svc_e2e_tests.cc +++ b/pc/test/svc_e2e_tests.cc @@ -122,6 +122,11 @@ class SvcTest : public testing::TestWithParam { VideoCodecConfig video_codec_config; }; +std::string SvcTestNameGenerator( + const testing::TestParamInfo& info) { + return info.param.scalability_mode; +} + } // namespace // Records how many frames are seen for each spatial and temporal index at the @@ -275,7 +280,8 @@ INSTANTIATE_TEST_SUITE_P( SvcTest, Values(SvcTestParameters{cricket::kVp8CodecName, "L1T1", 1, 1}, SvcTestParameters{cricket::kVp8CodecName, "L1T2", 1, 2}, - SvcTestParameters{cricket::kVp8CodecName, "L1T3", 1, 3})); + SvcTestParameters{cricket::kVp8CodecName, "L1T3", 1, 3}), + SvcTestNameGenerator); #if RTC_ENABLE_VP9 INSTANTIATE_TEST_SUITE_P( SvcTestVP9, @@ -291,7 +297,8 @@ INSTANTIATE_TEST_SUITE_P( SvcTestParameters{cricket::kVp9CodecName, "L2T2_KEY_SHIFT", 2, 2}, SvcTestParameters{cricket::kVp9CodecName, "L2T3_KEY", 2, 3}, SvcTestParameters{cricket::kVp9CodecName, "L3T1", 3, 1}, - SvcTestParameters{cricket::kVp9CodecName, "L3T3", 3, 3})); + SvcTestParameters{cricket::kVp9CodecName, "L3T3", 3, 3}), + SvcTestNameGenerator); // TODO(bugs.webrtc.org/11607): Fix and enable tests // SvcTestParameters{cricket::kVp9CodecName, "L3T3_KEY", 3, 3}, // SvcTestParameters{cricket::kVp9CodecName, "S2T1", 2, 1},