From c4e506ebdf5b6f632d3bdf563812e087ea891939 Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 20 Nov 2019 17:07:11 +0100 Subject: [PATCH] Fix writing into closed FrameWriter when dumping video in PC framework Bug: webrtc:10138 Change-Id: I2b8e2cac2903c957dab1170ba098880a4f0252e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160049 Reviewed-by: Mirko Bonadei Commit-Queue: Artem Titov Cr-Commit-Position: refs/heads/master@{#29853} --- test/pc/e2e/peer_connection_quality_test.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/pc/e2e/peer_connection_quality_test.cc b/test/pc/e2e/peer_connection_quality_test.cc index 9dba0f549b..a5fa65ad49 100644 --- a/test/pc/e2e/peer_connection_quality_test.cc +++ b/test/pc/e2e/peer_connection_quality_test.cc @@ -1032,15 +1032,15 @@ void PeerConnectionE2EQualityTest::TearDownCall() { alice_->pc()->Close(); bob_->pc()->Close(); + alice_video_sources_.clear(); + bob_video_sources_.clear(); + alice_.reset(); + bob_.reset(); + for (const auto& video_writer : video_writers_) { video_writer->Close(); } - - alice_video_sources_.clear(); - bob_video_sources_.clear(); video_writers_.clear(); - alice_.reset(); - bob_.reset(); } test::VideoFrameWriter* PeerConnectionE2EQualityTest::MaybeCreateVideoWriter(