From c4e1ab515b5244853f26975ba3ef6cc54229cd2d Mon Sep 17 00:00:00 2001 From: "agalusza@google.com" Date: Tue, 6 Aug 2013 18:27:41 +0000 Subject: [PATCH] Added Decoding with errors API to video_coding.h and removed unused DecodeError enum. R=marpan@google.com, mikhal@webrtc.org Review URL: https://webrtc-codereview.appspot.com/1937004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4497 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../video_coding/main/interface/video_coding.h | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/webrtc/modules/video_coding/main/interface/video_coding.h b/webrtc/modules/video_coding/main/interface/video_coding.h index 9f6876f8e5..51aa4bb0f7 100644 --- a/webrtc/modules/video_coding/main/interface/video_coding.h +++ b/webrtc/modules/video_coding/main/interface/video_coding.h @@ -71,11 +71,6 @@ public: kReferenceSelection }; - enum DecodeErrors { - kNoDecodeErrors, - kAllowDecodeErrors - }; - static VideoCodingModule* Create(const int32_t id); static VideoCodingModule* Create(const int32_t id, @@ -581,6 +576,13 @@ public: virtual int SetReceiverRobustnessMode(ReceiverRobustness robustnessMode, VCMDecodeErrorMode errorMode) = 0; + // Set the decode error mode. The mode decides which errors (if any) are + // allowed in decodable frames. Note that setting decode_error_mode to + // anything other than kWithErrors without enabling nack will cause + // long-term freezes (resulting from frequent key frame requests) if + // packet loss occurs. + virtual void SetDecodeErrorMode(VCMDecodeErrorMode decode_error_mode) = 0; + // Sets the maximum number of sequence numbers that we are allowed to NACK // and the oldest sequence number that we will consider to NACK. If a // sequence number older than |max_packet_age_to_nack| is missing