From c4deaaa7c55c33abda6addc4c7016006f0dc72fe Mon Sep 17 00:00:00 2001 From: Sam Zackrisson Date: Thu, 16 Aug 2018 11:42:27 +0200 Subject: [PATCH] Set AEC2 suppression to high by default The other modes are little-tested and nigh-unsupported. Surrounding APM code is tuned for high suppression. Both WebRtcVoiceEngine and Chrome default all usage to high suppression. Bug: webrtc:9535 Change-Id: Ic1a6bd90b86a994338addfef7f473132ab43092a Reviewed-on: https://webrtc-review.googlesource.com/91865 Reviewed-by: Alex Loiko Commit-Queue: Sam Zackrisson Cr-Commit-Position: refs/heads/master@{#24313} --- modules/audio_processing/audio_processing_unittest.cc | 2 ++ modules/audio_processing/echo_cancellation_impl.cc | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/audio_processing/audio_processing_unittest.cc b/modules/audio_processing/audio_processing_unittest.cc index 3776474a66..346c2a2c40 100644 --- a/modules/audio_processing/audio_processing_unittest.cc +++ b/modules/audio_processing/audio_processing_unittest.cc @@ -187,6 +187,8 @@ void EnableAllAPComponents(AudioProcessing* ap) { EXPECT_NOERR(ap->echo_cancellation()->enable_drift_compensation(true)); EXPECT_NOERR(ap->echo_cancellation()->enable_metrics(true)); EXPECT_NOERR(ap->echo_cancellation()->enable_delay_logging(true)); + EXPECT_NOERR(ap->echo_cancellation()->set_suppression_level( + EchoCancellation::SuppressionLevel::kModerateSuppression)); EXPECT_NOERR(ap->echo_cancellation()->Enable(true)); EXPECT_NOERR(ap->gain_control()->set_mode(GainControl::kAdaptiveAnalog)); diff --git a/modules/audio_processing/echo_cancellation_impl.cc b/modules/audio_processing/echo_cancellation_impl.cc index 15cd0db751..9feaea7c3f 100644 --- a/modules/audio_processing/echo_cancellation_impl.cc +++ b/modules/audio_processing/echo_cancellation_impl.cc @@ -109,7 +109,7 @@ EchoCancellationImpl::EchoCancellationImpl(rtc::CriticalSection* crit_render, crit_capture_(crit_capture), drift_compensation_enabled_(false), metrics_enabled_(false), - suppression_level_(kModerateSuppression), + suppression_level_(kHighSuppression), stream_drift_samples_(0), was_stream_drift_set_(false), stream_has_echo_(false),