From c48a2653466f926ecc1d259a16ede304333fc14b Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Tue, 15 Nov 2022 10:19:08 +0000 Subject: [PATCH] Do not log on stderr on Android tests. On Pixel 2, this causes an increase in flakiness. This needs to be reenabled once the root cause is fixed. Bug: chromium:1384172, b/259113795 Change-Id: Ie94d3e2daad3a2de5af673c763362ea1b42fde7d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283522 Reviewed-by: Jeremy Leconte Owners-Override: Mirko Bonadei Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#38623} --- test/test_main_lib.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/test_main_lib.cc b/test/test_main_lib.cc index 9968adf32e..a542777247 100644 --- a/test/test_main_lib.cc +++ b/test/test_main_lib.cc @@ -76,7 +76,13 @@ ABSL_FLAG(bool, false, "Tells to initialize new API for exporting performance metrics"); +// TODO(crbug.com/1384172): Re-enable logs by default once the issue with +// logcat is solved. +#if defined(WEBRTC_ANDROID) +ABSL_FLAG(bool, logs, false, "print logs to stderr"); +#else ABSL_FLAG(bool, logs, true, "print logs to stderr"); +#endif ABSL_FLAG(bool, verbose, false, "verbose logs to stderr"); ABSL_FLAG(std::string,