From c42d37646f8e28a54e628cc68c6c3c3c0bfa68f4 Mon Sep 17 00:00:00 2001 From: hbos Date: Thu, 24 Nov 2016 01:17:52 -0800 Subject: [PATCH] DataChannelInterface: Remove default implementation of methods. This can land as soon as https://codereview.chromium.org/2520033005/ has landed. BUG=chromium:654927 Review-Url: https://codereview.webrtc.org/2524033002 Cr-Commit-Position: refs/heads/master@{#15221} --- webrtc/api/datachannelinterface.h | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/webrtc/api/datachannelinterface.h b/webrtc/api/datachannelinterface.h index ddeb1e5636..8b788c0468 100644 --- a/webrtc/api/datachannelinterface.h +++ b/webrtc/api/datachannelinterface.h @@ -125,13 +125,10 @@ class DataChannelInterface : public rtc::RefCountInterface { virtual int id() const = 0; virtual DataState state() const = 0; - // TODO(hbos): Default implementations of [messages/bytes]_[sent/received] as - // to not break Chromium. Fix Chromium's implementation as soon as this rolls. - // crbug.com/654927 - virtual uint32_t messages_sent() const { return 0; } - virtual uint64_t bytes_sent() const { return 0; } - virtual uint32_t messages_received() const { return 0; } - virtual uint64_t bytes_received() const { return 0; } + virtual uint32_t messages_sent() const = 0; + virtual uint64_t bytes_sent() const = 0; + virtual uint32_t messages_received() const = 0; + virtual uint64_t bytes_received() const = 0; // The buffered_amount returns the number of bytes of application data // (UTF-8 text and binary data) that have been queued using SendBuffer but // have not yet been transmitted to the network.