From c4152a3bb1eab79d91740f71f3ae8fcfe5bef201 Mon Sep 17 00:00:00 2001 From: Florent Castelli Date: Fri, 3 Sep 2021 13:41:53 +0200 Subject: [PATCH] Add TSAN suppression for usrsctp Both suppressions are related to the same lock and can be triggered from 2 different API calls. Since those calls are causing a significant amount of flaky tests, I opted to suppress the issue for now, until we can either find a solution upstream or replace usrsctp with DcSCTP. Bug: webrtc:12823 Change-Id: I0ae49c94810264f94838b97781080cf5e6e4b24c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231136 Commit-Queue: Florent Castelli Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#34916} --- tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc b/tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc index 3eb85e9fb5..a704018e17 100644 --- a/tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc +++ b/tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc @@ -45,6 +45,11 @@ char kTSanDefaultSuppressions[] = // https://code.google.com/p/webrtc/issues/detail?id=5151 "race:sctp_close\n" + // lock-order-inversion in usrsctp + // TODO(orphis): https://crbug.com/webrtc/12823 + "deadlock:usrsctp_conninput\n" + "deadlock:usrsctp_connect\n" + // Potential deadlocks detected after roll in r6516. // https://code.google.com/p/webrtc/issues/detail?id=3509 "deadlock:webrtc::test::UdpSocketManagerPosixImpl::RemoveSocket\n"