admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unneeded check_includes.

Browse Source 
To be honest I don't know why the common_types.h includes from rtc_base
don't trip the check. I'd expect that to require that webrtc_common
depends on rtc_base, and in that case we're in trouble.

Bug: webrtc:6828,webrtc:7745
Change-Id: Id15055483e4fe40cffa67b973cc54cae3ed26112
Reviewed-on: https://webrtc-review.googlesource.com/28041
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21156}
This commit is contained in:
Patrik Höglund 2017-12-01 11:44:12 +01:00 committed by Commit Bot
parent a4b7dcf105
commit c2400dd5b2
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
BUILD.gn
View File

@ -344,13 +344,6 @@ if (!build_with_chromium) {
}
rtc_static_library("webrtc_common") {
# TODO(mbonadei): Remove (bugs.webrtc.org/7745)
# Enabling GN check triggers cyclic dependency error:
# :webrtc_common ->
# api:video_frame_api ->
# system_wrappers:system_wrappers ->
# webrtc_common
check_includes = false
sources = [
"common_types.cc",
"common_types.h",