From c14b2335d9e8fe0f71cdddcbe43f2fb8d4a42906 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sami=20Kalliom=C3=A4ki?= Date: Wed, 14 Aug 2019 13:27:47 +0200 Subject: [PATCH] Disable the most flaky tests on iOS. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Disables: - RtpVideoSenderTest.DoesNotRetrasmitAckedPackets - VideoReceiveStreamTestWithFakeDecoder.RenderedFrameUpdatesGetSources Bug: webrtc:10870, webrtc:10872, webrtc:10873 Change-Id: I410f781c30e45387c35055bf97424a68658174d3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148984 Commit-Queue: Sami Kalliomäki Reviewed-by: Magnus Flodman Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/master@{#28858} --- call/rtp_video_sender_unittest.cc | 5 +++++ video/video_receive_stream_unittest.cc | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/call/rtp_video_sender_unittest.cc b/call/rtp_video_sender_unittest.cc index 45888a8f50..1fb24abd42 100644 --- a/call/rtp_video_sender_unittest.cc +++ b/call/rtp_video_sender_unittest.cc @@ -389,7 +389,12 @@ TEST(RtpVideoSenderTest, FrameCountCallbacks) { // Integration test verifying that ack of packet via TransportFeedback means // that the packet is removed from RtpPacketHistory and won't be retransmitted // again. +// TODO(crbug.com/webrtc/10873): Re-enable on iOS +#if defined(WEBRTC_IOS) +TEST(RtpVideoSenderTest, DISABLED_DoesNotRetrasmitAckedPackets) { +#else TEST(RtpVideoSenderTest, DoesNotRetrasmitAckedPackets) { +#endif const int64_t kTimeoutMs = 500; RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, diff --git a/video/video_receive_stream_unittest.cc b/video/video_receive_stream_unittest.cc index 6d88f67e92..2f9564e239 100644 --- a/video/video_receive_stream_unittest.cc +++ b/video/video_receive_stream_unittest.cc @@ -313,7 +313,13 @@ TEST_F(VideoReceiveStreamTestWithFakeDecoder, PassesPacketInfos) { EXPECT_THAT(fake_renderer_.packet_infos(), ElementsAreArray(packet_infos)); } +// TODO(crbug.com/webrtc/10872): Re-enable on iOS +#if defined(WEBRTC_IOS) +TEST_F(VideoReceiveStreamTestWithFakeDecoder, + DISABLED_RenderedFrameUpdatesGetSources) { +#else TEST_F(VideoReceiveStreamTestWithFakeDecoder, RenderedFrameUpdatesGetSources) { +#endif constexpr uint32_t kSsrc = 1111; constexpr uint32_t kCsrc = 9001; constexpr uint32_t kRtpTimestamp = 12345;