From c0c3e966d34b12bc776040f3d1fb7d0aa1987d8d Mon Sep 17 00:00:00 2001 From: Yves Gerey Date: Sun, 10 Mar 2019 10:01:24 +0000 Subject: [PATCH] Revert "DCHECK feedback_rtt is positive" This reverts commit 37d4f91db3fd1d0e023a820d0cda86bb786a0f72. Reason for revert: Breaks downstream Android projects. Original change's description: > DCHECK feedback_rtt is positive > > Bug: None > Change-Id: I6eb10d6a20a679fff08f604441f8e58dcd417608 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126464 > Commit-Queue: Evan Shrubsole > Reviewed-by: Sebastian Jansson > Cr-Commit-Position: refs/heads/master@{#27034} TBR=srte@webrtc.org,yinwa@webrtc.org,eshr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I412cc3bf9fd6991d3afa68c0fd9289bfc84a98cd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126622 Reviewed-by: Yves Gerey Commit-Queue: Yves Gerey Cr-Commit-Position: refs/heads/master@{#27047} --- modules/congestion_controller/goog_cc/goog_cc_network_control.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc index 64f7f27883..807e1d89f2 100644 --- a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc +++ b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc @@ -383,7 +383,6 @@ NetworkControlUpdate GoogCcNetworkController::OnTransportPacketsFeedback( for (const auto& feedback : feedbacks) { TimeDelta feedback_rtt = report.feedback_time - feedback.sent_packet.send_time; - RTC_DCHECK_GE(feedback_rtt.ms(), 0); TimeDelta min_pending_time = feedback.receive_time - max_recv_time; TimeDelta propagation_rtt = feedback_rtt - min_pending_time; max_feedback_rtt = std::max(max_feedback_rtt, feedback_rtt);