From c0ada864b2811ab3394f97adf5cbaeaf4632eb40 Mon Sep 17 00:00:00 2001 From: "turaj@webrtc.org" Date: Thu, 31 Jan 2013 18:21:06 +0000 Subject: [PATCH] fix for issue 281. A reverse copy is removed. The index to src buffer could be -1, this happens very often. The reverse copy is not needed as the content of the destination is overwritten further down in "WebRtcIlbcfix_CbConstruct()" Bug=issue281 TEST=manual test over 1600 files TIMIT database, all outputs are bit-exact with the ones generated from head revision. Local run of asan does not generate any warning. Review URL: https://webrtc-codereview.appspot.com/1063013 git-svn-id: http://webrtc.googlecode.com/svn/trunk@3447 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/modules/audio_coding/codecs/ilbc/decode_residual.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.c b/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.c index 4bc1cd3cf8..da56db4689 100644 --- a/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.c +++ b/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.c @@ -26,7 +26,6 @@ #include "xcorr_coef.h" #include "lsf_check.h" - /*----------------------------------------------------------------* * frame residual decoder function (subrutine to iLBC_decode) *---------------------------------------------------------------*/ @@ -81,11 +80,6 @@ void WebRtcIlbcfix_DecodeResidual( } else {/* put adaptive part in the beginning */ - /* create reversed vectors for prediction */ - - WebRtcSpl_MemCpyReversedOrder(reverseDecresidual+diff, - &decresidual[(iLBC_encbits->startIdx+1)*SUBL-1-STATE_LEN], diff); - /* setup memory */ meml_gotten = iLBCdec_inst->state_short_len;