From c065cc797ddd6e3ae3047f56a26bee51b5fbbdab Mon Sep 17 00:00:00 2001 From: Minyue Li Date: Wed, 27 May 2015 10:01:10 +0200 Subject: [PATCH] Clarify boolean flags in neteq_opus_quality_test. Note that the use of boolean flags in gflags is a bit unnatural. For setting a boolean flag to false: putting "no" in front of its name (see http://gflags.github.io/gflags/) We make this clearer by defaulting boolean flags to false, and clarifying it in the description. BUG= R=tina.legrand@webrtc.org Review URL: https://webrtc-codereview.appspot.com/53539004 Cr-Commit-Position: refs/heads/master@{#9293} --- .../audio_coding/neteq/test/neteq_opus_quality_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc b/webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc index 29cf84e48c..3a3b3269cf 100644 --- a/webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc +++ b/webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc @@ -81,9 +81,9 @@ DEFINE_int32(reported_loss_rate, 10, "Reported percentile of packet loss."); static const bool reported_loss_rate_dummy = RegisterFlagValidator(&FLAGS_reported_loss_rate, &ValidatePacketLossRate); -DEFINE_bool(fec, true, "Whether to enable FEC for encoding."); +DEFINE_bool(fec, false, "Enable FEC for encoding (-nofec to disable)."); -DEFINE_bool(dtx, true, "Whether to enable DTX for encoding."); +DEFINE_bool(dtx, false, "Enable DTX for encoding (-nodtx to disable)."); // Define switch for number of sub packets to repacketize. static bool ValidateSubPackets(const char* flagname, int32_t value) {