From c03d6e965e1f54aeadd670e491eabe5fdb8db968 Mon Sep 17 00:00:00 2001 From: Fabian Bergmark Date: Tue, 15 Jun 2021 15:46:56 +0200 Subject: [PATCH] Support Java_Buffer_toI420 returning null MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:12877 Change-Id: Ib9c8c62b350e644b17a3194e4208df6b06a4d9b1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222582 Reviewed-by: Xavier Lepaul‎ Reviewed-by: Evan Shrubsole Reviewed-by: Henrik Boström Commit-Queue: Fabian Bergmark Cr-Commit-Position: refs/heads/master@{#34296} --- sdk/android/src/jni/video_frame.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sdk/android/src/jni/video_frame.cc b/sdk/android/src/jni/video_frame.cc index dd3562f540..98728032e8 100644 --- a/sdk/android/src/jni/video_frame.cc +++ b/sdk/android/src/jni/video_frame.cc @@ -179,6 +179,10 @@ rtc::scoped_refptr AndroidVideoBuffer::ToI420() { JNIEnv* jni = AttachCurrentThreadIfNeeded(); ScopedJavaLocalRef j_i420_buffer = Java_Buffer_toI420(jni, j_video_frame_buffer_); + // In case I420 conversion fails, we propagate the nullptr. + if (j_i420_buffer.is_null()) { + return nullptr; + } // We don't need to retain the buffer because toI420 returns a new object that // we are assumed to take the ownership of.