admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removes unnecessary destructor checks in tests.

Browse Source 
Removes checks that are not relevant to the particular tests. The checks
create dependencies on the CallTest base class. This prepares for
further refactoring in CallTest.

Bug: webrtc:9510
Change-Id: Icd2bb4fe168aabd377d349b1de3de833fb7ae075
Reviewed-on: https://webrtc-review.googlesource.com/87823
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23902}
This commit is contained in:
Sebastian Jansson 2018-07-10 11:06:27 +02:00 committed by Commit Bot
parent 23402b2247
commit bed801e005
10 changed files with 0 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
video/end_to_end_tests/bandwidth_tests.cc
View File

@ -26,11 +26,6 @@ class BandwidthEndToEndTest : public test::CallTest,
public:
BandwidthEndToEndTest() : field_trial_(GetParam()) {}
virtual ~BandwidthEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
private:
test::ScopedFieldTrials field_trial_;
};

5
video/end_to_end_tests/call_operation_tests.cc
View File

@ -23,11 +23,6 @@ class CallOperationEndToEndTest
public:
CallOperationEndToEndTest() : field_trial_(GetParam()) {}
virtual ~CallOperationEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
private:
test::ScopedFieldTrials field_trial_;
};

5
video/end_to_end_tests/codec_tests.cc
View File

@ -28,11 +28,6 @@ class CodecEndToEndTest : public test::CallTest,
public:
CodecEndToEndTest() : field_trial_(GetParam()) {}
virtual ~CodecEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
private:
test::ScopedFieldTrials field_trial_;
};

5
video/end_to_end_tests/fec_tests.cc
View File

@ -23,11 +23,6 @@ class FecEndToEndTest : public test::CallTest,
public:
FecEndToEndTest() : field_trial_(GetParam()) {}
virtual ~FecEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
private:
test::ScopedFieldTrials field_trial_;
};

3
video/end_to_end_tests/multi_codec_receive_tests.cc
View File

@ -162,9 +162,6 @@ class MultiCodecReceiveTest : public test::CallTest {
}
virtual ~MultiCodecReceiveTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
task_queue_.SendTask([this]() {
send_transport_.reset();
receive_transport_.reset();

5
video/end_to_end_tests/multi_stream_tests.cc
View File

@ -23,11 +23,6 @@ class MultiStreamEndToEndTest
public:
MultiStreamEndToEndTest() : field_trial_(GetParam()) {}
virtual ~MultiStreamEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
private:
test::ScopedFieldTrials field_trial_;
};

4
video/end_to_end_tests/probing_tests.cc
View File

@ -19,8 +19,6 @@ class ProbingEndToEndTest : public test::CallTest,
ProbingEndToEndTest() : field_trial_(GetParam()) {}
virtual ~ProbingEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
private:
@ -41,8 +39,6 @@ class ProbingTest : public test::EndToEndTest {
state_(0),
sender_call_(nullptr) {}
~ProbingTest() {}
Call::Config GetSenderCallConfig() override {
Call::Config config(event_log_.get());
config.bitrate_config.start_bitrate_bps = start_bitrate_bps_;

5
video/end_to_end_tests/retransmission_tests.cc
View File

@ -23,11 +23,6 @@ class RetransmissionEndToEndTest
public:
RetransmissionEndToEndTest() : field_trial_(GetParam()) {}
virtual ~RetransmissionEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
protected:
void DecodesRetransmittedFrame(bool enable_rtx, bool enable_red);
void ReceivesPliAndRecovers(int rtp_history_ms);

2
video/end_to_end_tests/transport_feedback_tests.cc
View File

@ -25,8 +25,6 @@ class TransportFeedbackEndToEndTest
TransportFeedbackEndToEndTest() : field_trial_(GetParam()) {}
virtual ~TransportFeedbackEndToEndTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
}
private:

3
video/picture_id_tests.cc
View File

@ -210,9 +210,6 @@ class PictureIdTest : public test::CallTest,
PictureIdTest() : num_temporal_layers_(GetParam()) {}
virtual ~PictureIdTest() {
EXPECT_EQ(nullptr, video_send_stream_);
EXPECT_TRUE(video_receive_streams_.empty());
task_queue_.SendTask([this]() {
send_transport_.reset();
receive_transport_.reset();