From be63fd644f2506a34c4d8b0239edc50d796884ac Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Tue, 17 Sep 2013 09:33:17 +0000 Subject: [PATCH] Initialize CodecInst structs in test_api_audio.cc. Fixes errors detected by DrMemory on Windows. BUG=2382 R=stefan@webrtc.org Review URL: https://webrtc-codereview.appspot.com/2228004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@4764 4adac7df-926f-26a2-2b94-8c16560cd09d --- tools/valgrind-webrtc/drmemory/suppressions.txt | 6 ------ webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc | 3 +++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/valgrind-webrtc/drmemory/suppressions.txt b/tools/valgrind-webrtc/drmemory/suppressions.txt index 85d4286eb1..fb11db2858 100644 --- a/tools/valgrind-webrtc/drmemory/suppressions.txt +++ b/tools/valgrind-webrtc/drmemory/suppressions.txt @@ -39,12 +39,6 @@ system call NtUserGetThreadDesktop parameter value #1 *!webrtc::ScreenCapturerTest_StartCapturer_Test::TestBody *!testing::internal::HandleSehExceptionsInMethodIfSupported -UNINITIALIZED READ -name=https://code.google.com/p/webrtc/issues/detail?id=2382 -*!webrtc::ModuleRtpRtcpImpl::RegisterSendPayload -... -*!testing::internal::HandleSehExceptionsInMethodIfSupported - UNINITIALIZED READ name=https://code.google.com/p/libyuv/issues/detail?id=263 *!ScaleAddRows_SSE2 diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc index 6f6caf5500..0470def399 100644 --- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc +++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc @@ -205,6 +205,7 @@ TEST_F(RtpRtcpAudioTest, Basic) { 96, 0, -1, NULL, 0)); CodecInst voice_codec; + memset(&voice_codec, 0, sizeof(voice_codec)); voice_codec.pltype = 96; voice_codec.plfreq = 8000; memcpy(voice_codec.plname, "PCMU", 5); @@ -236,6 +237,7 @@ TEST_F(RtpRtcpAudioTest, Basic) { TEST_F(RtpRtcpAudioTest, RED) { CodecInst voice_codec; + memset(&voice_codec, 0, sizeof(voice_codec)); voice_codec.pltype = 96; voice_codec.plfreq = 8000; memcpy(voice_codec.plname, "PCMU", 5); @@ -308,6 +310,7 @@ TEST_F(RtpRtcpAudioTest, RED) { TEST_F(RtpRtcpAudioTest, DTMF) { CodecInst voice_codec; + memset(&voice_codec, 0, sizeof(voice_codec)); voice_codec.pltype = 96; voice_codec.plfreq = 8000; memcpy(voice_codec.plname, "PCMU", 5);