admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""

Browse Source 
This reverts commit 898ae5d74b3a7261c6993315bd2aa9e59cc493c0.

Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).

Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
> 
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
> 
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
> 
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
> 
> TBR: kwiberg@webrtc.org
> No-Try: True
> Bug: webrtc:9419
> Change-Id: I1b929a5a702ca8010c557612004f538256be8a4b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158889
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29693}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I39fe67e388857721f239b0042a33ef8ef90f2036
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158890
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29694}
This commit is contained in:
Mirko Bonadei 2019-11-05 15:57:55 +00:00 committed by Commit Bot
parent 898ae5d74b
commit be43b7c4d7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -111,7 +111,7 @@ config("common_inherited_config") {
cflags = []
ldflags = []
if (rtc_enable_symbol_export || is_component_build) {
if (rtc_enable_symbol_export) {
defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ]
}