From bd50a843367897779f77b3526e0b1411aaed8389 Mon Sep 17 00:00:00 2001 From: Seth Hampson Date: Tue, 12 Mar 2019 19:40:17 +0000 Subject: [PATCH] Revert "Reland "DCHECK feedback_rtt is positive"" This reverts commit ab0d03dcaaa98677348d15352f7bc1e8e066180f. Reason for revert: Broke webrtc importer. Original change's description: > Reland "DCHECK feedback_rtt is positive" > > This is a reland of 37d4f91db3fd1d0e023a820d0cda86bb786a0f72 > Reason for reland: Got Aliby for Android FEC test flakes. > > Original change's description: > > DCHECK feedback_rtt is positive > > > > Bug: None > > Change-Id: I6eb10d6a20a679fff08f604441f8e58dcd417608 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126464 > > Commit-Queue: Evan Shrubsole > > Reviewed-by: Sebastian Jansson > > Cr-Commit-Position: refs/heads/master@{#27034} > > Bug: None > Change-Id: Iacacda9e3b141c69189f7931a1ec63d74b2dd845 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126920 > Commit-Queue: Sebastian Jansson > Reviewed-by: Ying Wang > Reviewed-by: Sebastian Jansson > Cr-Commit-Position: refs/heads/master@{#27082} TBR=srte@webrtc.org,yinwa@webrtc.org,yvesg@webrtc.org,yvesg@google.com,eshr@google.com Change-Id: Ia59f20019309c1e0b44029179d63558e92d39a85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127324 Reviewed-by: Seth Hampson Commit-Queue: Seth Hampson Cr-Commit-Position: refs/heads/master@{#27085} --- modules/congestion_controller/goog_cc/goog_cc_network_control.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc index 7f331da0b9..283ca983e9 100644 --- a/modules/congestion_controller/goog_cc/goog_cc_network_control.cc +++ b/modules/congestion_controller/goog_cc/goog_cc_network_control.cc @@ -381,7 +381,6 @@ NetworkControlUpdate GoogCcNetworkController::OnTransportPacketsFeedback( for (const auto& feedback : feedbacks) { TimeDelta feedback_rtt = report.feedback_time - feedback.sent_packet.send_time; - RTC_DCHECK_GE(feedback_rtt.ms(), 0); TimeDelta min_pending_time = feedback.receive_time - max_recv_time; TimeDelta propagation_rtt = feedback_rtt - min_pending_time; max_feedback_rtt = std::max(max_feedback_rtt, feedback_rtt);