admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable G722 and iLBC tests failing with the new version of UBSan.

Browse Source 
Bug: webrtc:345525069
Change-Id: Iebe6a75252393f2bdf1e91b309f1b918708d413c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353860
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42443}
This commit is contained in:
Mirko Bonadei 2024-06-07 08:38:55 +00:00 committed by WebRTC LUCI CQ
parent 32fdb04f1f
commit bd4dd67dde
5 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/audio_coding/test/EncodeDecodeTest.cc
View File

@ -234,10 +234,14 @@ void EncodeDecodeTest::Perform() {
{107, {"L16", 8000, 1}}, {108, {"L16", 16000, 1}},
{109, {"L16", 32000, 1}}, {0, {"PCMU", 8000, 1}},
{8, {"PCMA", 8000, 1}},
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722 and iLBC.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
#ifdef WEBRTC_CODEC_ILBC
{102, {"ILBC", 8000, 1}},
#endif
{9, {"G722", 8000, 1}}};
{9, {"G722", 8000, 1}},
#endif
};
int file_num = 0;
for (const auto& send_codec : send_codecs) {
RTPFile rtpFile;

7
modules/audio_coding/test/TestAllCodecs.cc
View File

@ -152,6 +152,9 @@ void TestAllCodecs::Perform() {
// All codecs are tested for all allowed sampling frequencies, rates and
// packet sizes.
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
test_count_++;
OpenOutFile(test_count_);
char codec_g722[] = "G722";
@ -168,6 +171,9 @@ void TestAllCodecs::Perform() {
RegisterSendCodec(codec_g722, 16000, 64000, 960, 0);
Run(channel_a_to_b_);
outfile_b_.Close();
#endif
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove iLBC.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
#ifdef WEBRTC_CODEC_ILBC
test_count_++;
OpenOutFile(test_count_);
@ -181,6 +187,7 @@ void TestAllCodecs::Perform() {
RegisterSendCodec(codec_ilbc, 8000, 15200, 320, 0);
Run(channel_a_to_b_);
outfile_b_.Close();
#endif
#endif
test_count_++;
OpenOutFile(test_count_);

3
modules/audio_coding/test/TestRedFec.cc
View File

@ -77,6 +77,8 @@ void TestRedFec::Perform() {
Run();
_outFileB.Close();
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
// Switch to a 16 kHz codec; RED should be switched off.
RegisterSendCodec(_acmA, {"G722", 8000, 1}, Vad::kVadAggressive, false);
@ -96,6 +98,7 @@ void TestRedFec::Perform() {
OpenOutFile(_testCntr);
Run();
_outFileB.Close();
#endif
RegisterSendCodec(_acmA, {"opus", 48000, 2}, absl::nullopt, false);

9
modules/audio_coding/test/TestStereo.cc
View File

@ -170,6 +170,8 @@ void TestStereo::Perform() {
audio_channels = 2;
codec_channels = 2;
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
// All codecs are tested for all allowed sampling frequencies, rates and
// packet sizes.
channel_a2b_->set_codec_mode(kStereo);
@ -189,6 +191,7 @@ void TestStereo::Perform() {
RegisterSendCodec('A', codec_g722, 16000, 64000, 960, codec_channels);
Run(channel_a2b_, audio_channels, codec_channels);
out_file_.Close();
#endif
channel_a2b_->set_codec_mode(kStereo);
test_cntr_++;
@ -294,12 +297,15 @@ void TestStereo::Perform() {
audio_channels = 1;
codec_channels = 2;
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
test_cntr_++;
channel_a2b_->set_codec_mode(kStereo);
OpenOutFile(test_cntr_);
RegisterSendCodec('A', codec_g722, 16000, 64000, 160, codec_channels);
Run(channel_a2b_, audio_channels, codec_channels);
out_file_.Close();
#endif
test_cntr_++;
channel_a2b_->set_codec_mode(kStereo);
@ -350,12 +356,15 @@ void TestStereo::Perform() {
codec_channels = 1;
channel_a2b_->set_codec_mode(kMono);
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
// Run stereo audio and mono codec.
test_cntr_++;
OpenOutFile(test_cntr_);
RegisterSendCodec('A', codec_g722, 16000, 64000, 160, codec_channels);
Run(channel_a2b_, audio_channels, codec_channels);
out_file_.Close();
#endif
test_cntr_++;
OpenOutFile(test_cntr_);

3
modules/audio_coding/test/TestVADDTX.cc
View File

@ -177,7 +177,10 @@ void TestVadDtx::Run(absl::string_view in_filename,
TestWebRtcVadDtx::TestWebRtcVadDtx() : output_file_num_(0) {}
void TestWebRtcVadDtx::Perform() {
// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove iLBC.
#if defined(__has_feature) && !__has_feature(undefined_behavior_sanitizer)
RunTestCases({"ILBC", 8000, 1});
#endif
RunTestCases({"opus", 48000, 2});
}