admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing DCHECK in turnport.cc that was broken by refactoring.

Browse Source 
"PROTO_TCP + secure bit" was turned into "PROTO_TLS" by this CL:
https://codereview.webrtc.org/2568833002

But a "DCHECK(proto == PROTO_TCP)" wasn't updated to take this into
account.

BUG=NONE
TBR=pthatcher@webrtc.org

Review-Url: https://codereview.webrtc.org/2859763003
Cr-Commit-Position: refs/heads/master@{#18000}
This commit is contained in:
deadbeef 2017-05-03 09:48:35 -07:00 committed by Commit bot
parent 4515fa0bed
commit bbe2a370f7
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/p2p/base/turnport.cc
View File

@ -376,7 +376,11 @@ bool TurnPort::CreateTurnClientSocket() {
}
void TurnPort::OnSocketConnect(rtc::AsyncPacketSocket* socket) {
RTC_DCHECK(server_address_.proto == PROTO_TCP);
// This slot should only be invoked if we're using a connection-oriented
// protocol.
RTC_DCHECK(server_address_.proto == PROTO_TCP ||
server_address_.proto == PROTO_TLS);
// Do not use this port if the socket bound to a different address than
// the one we asked for. This is seen in Chrome, where TCP sockets cannot be
// given a binding address, and the platform is expected to pick the