From bb02db25bbfab773fa1b08d18c5e935f0b402362 Mon Sep 17 00:00:00 2001 From: Harald Alvestrand Date: Thu, 8 Oct 2020 16:35:18 +0000 Subject: [PATCH] Break out some more pc/ compile targets Bug: webrtc:11967 Change-Id: I98f1fc24174ca3dc82c69ce8092f543ab172a095 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186843 Commit-Queue: Harald Alvestrand Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#32356} --- pc/BUILD.gn | 53 ++++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 46 insertions(+), 7 deletions(-) diff --git a/pc/BUILD.gn b/pc/BUILD.gn index 421ea604e6..047fc2253c 100644 --- a/pc/BUILD.gn +++ b/pc/BUILD.gn @@ -193,10 +193,6 @@ rtc_library("peerconnection") { "rtc_stats_traversal.h", "rtp_data_channel.cc", "rtp_data_channel.h", - "rtp_parameters_conversion.cc", - "rtp_parameters_conversion.h", - "rtp_transceiver.cc", - "rtp_transceiver.h", "sctp_data_channel.cc", "sctp_data_channel.h", "sdp_offer_answer.cc", # TODO: Make separate target when not circular @@ -229,8 +225,10 @@ rtc_library("peerconnection") { ":media_stream", ":peer_connection_message_handler", ":rtc_pc_base", + ":rtp_parameters_conversion", ":rtp_receiver", ":rtp_sender", + ":rtp_transceiver", ":stats_collector_interface", ":video_track_source", "../api:array_view", @@ -307,9 +305,26 @@ rtc_library("peer_connection_message_handler") { ] } -# Temporary empty target to permit fixing blockers that prevent landing -# https://webrtc-review.googlesource.com/c/src/+/186843 -rtc_source_set("rtp_parameters_conversion") { +rtc_library("rtp_transceiver") { + sources = [ + "rtp_transceiver.cc", + "rtp_transceiver.h", + ] + deps = [ + ":rtc_pc_base", + ":rtp_parameters_conversion", + ":rtp_receiver", + ":rtp_sender", + "../api:libjingle_peerconnection_api", + "../api:rtp_parameters", + "../rtc_base:checks", + "../rtc_base:logging", + ] + absl_deps = [ + "//third_party/abseil-cpp/absl/algorithm:container", + "//third_party/abseil-cpp/absl/strings", + "//third_party/abseil-cpp/absl/types:optional", + ] } rtc_library("rtp_receiver") { @@ -362,6 +377,28 @@ rtc_library("rtp_sender") { ] } +rtc_library("rtp_parameters_conversion") { + sources = [ + "rtp_parameters_conversion.cc", + "rtp_parameters_conversion.h", + ] + deps = [ + ":rtc_pc_base", + "../api:array_view", + "../api:libjingle_peerconnection_api", + "../api:rtc_error", + "../api:rtp_parameters", + "../media:rtc_media_base", + "../rtc_base:checks", + "../rtc_base:rtc_base", + ] + absl_deps = [ + "//third_party/abseil-cpp/absl/algorithm:container", + "//third_party/abseil-cpp/absl/strings", + "//third_party/abseil-cpp/absl/types:optional", + ] +} + rtc_library("dtmf_sender") { sources = [ "dtmf_sender.cc", @@ -704,8 +741,10 @@ if (rtc_include_tests) { ":media_stream", ":peerconnection", ":rtc_pc_base", + ":rtp_parameters_conversion", ":rtp_receiver", ":rtp_sender", + ":rtp_transceiver", ":video_track_source", "../api:array_view", "../api:audio_options_api",