From ba7e71b53a959b27767e3bf147b61f0cb6139e03 Mon Sep 17 00:00:00 2001 From: "philipp.hancke" Date: Mon, 12 Dec 2016 04:46:20 -0800 Subject: [PATCH] remove googViewLimitedResolution stat adaptReason in webrtcvideoengine2.h only defines NONE=0, CPU=1 and BANDWIDTH=2 so &0x4 can not happen anymore. This was probably never implemented in videoengine2 BUG=webrtc:6870 Review-Url: https://codereview.webrtc.org/1887773002 Cr-Commit-Position: refs/heads/master@{#15546} --- AUTHORS | 1 + webrtc/api/statscollector.cc | 2 -- webrtc/api/statstypes.cc | 2 -- webrtc/api/statstypes.h | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/AUTHORS b/AUTHORS index 379c4f316c..bd7d39fa8e 100644 --- a/AUTHORS +++ b/AUTHORS @@ -26,6 +26,7 @@ Matthias Liebig Maxim Potapov Pali Rohar Paul Kapustin +Philipp Hancke Rafael Lopez Diez Ralph Giles Riku Voipio diff --git a/webrtc/api/statscollector.cc b/webrtc/api/statscollector.cc index 7dc17da159..991ceb4fa4 100644 --- a/webrtc/api/statscollector.cc +++ b/webrtc/api/statscollector.cc @@ -251,8 +251,6 @@ void ExtractStats(const cricket::VideoSenderInfo& info, StatsReport* report) { (info.adapt_reason & 0x2) > 0); report->AddBoolean(StatsReport::kStatsValueNameCpuLimitedResolution, (info.adapt_reason & 0x1) > 0); - report->AddBoolean(StatsReport::kStatsValueNameViewLimitedResolution, - (info.adapt_reason & 0x4) > 0); if (info.qp_sum) report->AddInt(StatsReport::kStatsValueNameQpSum, *info.qp_sum); diff --git a/webrtc/api/statstypes.cc b/webrtc/api/statstypes.cc index 354f115011..4a5bd69b9d 100644 --- a/webrtc/api/statstypes.cc +++ b/webrtc/api/statstypes.cc @@ -598,8 +598,6 @@ const char* StatsReport::Value::display_name() const { return "googTrackId"; case kStatsValueNameTypingNoiseState: return "googTypingNoiseState"; - case kStatsValueNameViewLimitedResolution: - return "googViewLimitedResolution"; case kStatsValueNameWritable: return "googWritable"; } diff --git a/webrtc/api/statstypes.h b/webrtc/api/statstypes.h index 9501c299b6..e30760b47a 100644 --- a/webrtc/api/statstypes.h +++ b/webrtc/api/statstypes.h @@ -214,7 +214,6 @@ class StatsReport { kStatsValueNameTransmitBitrate, kStatsValueNameTransportType, kStatsValueNameTypingNoiseState, - kStatsValueNameViewLimitedResolution, kStatsValueNameWritable, };