admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove build hooks implementation from AAR-builds.

Browse Source 
It is unnecessary to include the build hooks implementation because we
don't use them. It was also causing errors because the interface the
class implements is not included in the AAR.

Also removes comments about re-enabling build hooks because it has grown
into something very Chromium specific and it is unlikely that we want to
re-enable them.

Bug: webrtc:8964, webrtc:8168
Change-Id: Ia95af13e90a5511554305d2688ced820e9914beb
Reviewed-on: https://webrtc-review.googlesource.com/61302
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22386}
This commit is contained in:
Sami Kalliomäki 2018-03-12 14:19:23 +01:00 committed by Commit Bot
parent 3e77afd0d2
commit b9f4bf29d0
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sdk/android/BUILD.gn
View File

@ -617,6 +617,7 @@ dist_jar("libwebrtc") {
direct_deps_only = true direct_deps_only = true
use_unprocessed_jars = true use_unprocessed_jars = true
requires_android = true requires_android = true
no_build_hooks = true
deps = [ deps = [
":libjingle_peerconnection_java", ":libjingle_peerconnection_java",

3
webrtc.gni
View File

@ -495,7 +495,6 @@ if (is_android) {
# Treat warnings as errors. # Treat warnings as errors.
javac_args = [ "-Werror" ] javac_args = [ "-Werror" ]
# TODO(sakal): Fix build hooks crbug.com/webrtc/8168
no_build_hooks = true no_build_hooks = true
} }
} }
@ -514,7 +513,6 @@ if (is_android) {
# Treat warnings as errors. # Treat warnings as errors.
javac_args = [ "-Werror" ] javac_args = [ "-Werror" ]
# TODO(sakal): Fix build hooks crbug.com/webrtc/8168
no_build_hooks = true no_build_hooks = true
} }
} }
@ -533,7 +531,6 @@ if (is_android) {
# Treat warnings as errors. # Treat warnings as errors.
javac_args = [ "-Werror" ] javac_args = [ "-Werror" ]
# TODO(sakal): Fix build hooks crbug.com/webrtc/8168
no_build_hooks = true no_build_hooks = true
} }
} }