From b951eb12c9c0a0ff2c585d3111f56c66df6f34e4 Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Tue, 25 Nov 2014 11:13:28 +0000 Subject: [PATCH] Add back EXPECT_TRUEs. These shouldn't fail, but EXPECT_TRUE gives nicer error messages that work in Release. These changes got through unreviewed in r7726. R=stefan@webrtc.org BUG= Review URL: https://webrtc-codereview.appspot.com/26249004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7745 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/video/rampup_tests.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/webrtc/video/rampup_tests.cc b/webrtc/video/rampup_tests.cc index 644cb70196..59f0fd43e9 100644 --- a/webrtc/video/rampup_tests.cc +++ b/webrtc/video/rampup_tests.cc @@ -116,9 +116,7 @@ void StreamObserver::OnReceiveBitrateChanged( bool StreamObserver::SendRtp(const uint8_t* packet, size_t length) { CriticalSectionScoped lock(crit_.get()); RTPHeader header; - bool parse_succeeded = rtp_parser_->Parse(packet, length, &header); - RTC_UNUSED(parse_succeeded); - assert(parse_succeeded); + EXPECT_TRUE(rtp_parser_->Parse(packet, length, &header)); receive_stats_->IncomingPacket(header, length, false); payload_registry_->SetIncomingPayloadType(header); remote_bitrate_estimator_->IncomingPacket( @@ -268,9 +266,7 @@ PacketReceiver::DeliveryStatus LowRateStreamObserver::DeliverPacket( const uint8_t* packet, size_t length) { CriticalSectionScoped lock(crit_.get()); RTPHeader header; - bool parse_succeeded = rtp_parser_->Parse(packet, length, &header); - RTC_UNUSED(parse_succeeded); - assert(parse_succeeded); + EXPECT_TRUE(rtp_parser_->Parse(packet, length, &header)); receive_stats_->IncomingPacket(header, length, false); remote_bitrate_estimator_->IncomingPacket( clock_->TimeInMilliseconds(), length - 12, header);