admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Build //base/test:google_test_runner for iOS device.

Browse Source 
It seems the build failure is fixed and it is required so that "testRunGoogleTests" would be invoked as a "xctest".

Bug: b/223364112
Change-Id: I2572af62d14c71e31b751c73a76e9f6e5d064ea8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254682
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36202}
This commit is contained in:
Jeremy Leconte 2022-03-15 09:08:29 +01:00 committed by WebRTC LUCI CQ
parent bc8c095537
commit b8ba8c9248
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc.gni
View File

@ -498,10 +498,8 @@ template("rtc_test") {
]
}
# When not targeting a simulator, building //base/test:google_test_runner
# fails, so it is added only when the test is not a real XCTest and when
# targeting a simulator.
if (is_ios && target_cpu == "x64" && rtc_include_tests) {
# Build //base/test:google_test_runner when the test is not a real XCTest.
if (is_ios && rtc_include_tests) {
if (!defined(invoker.is_xctest) || !invoker.is_xctest) {
xctest_module_target = "//base/test:google_test_runner"
}
@ -530,6 +528,7 @@ template("rtc_test") {
[ "//third_party/llvm-build/Release+Asserts/lib/libstdc++.so.6" ]
}
}
# TODO(crbug.com/webrtc/13556): Adding the .app folder in the runtime_deps
# shoulnd't be necessary. this code should be removed and the same solution
# as Chromium should be used.