Revert of Enabling 'gn check' on //webrtc/test. (patchset #3 id:90001 of https://codereview.webrtc.org/2815103005/ )
Reason for revert: Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. Original issue's description: > Reland of Enabling 'gn check' on //webrtc/test. (patchset #1 id:1 of https://codereview.webrtc.org/2817003002/ ) > > Reason for revert: > The original CL was breaking a downstream buildbot: https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%28Libfuzzer%29/builds/5429 > > This CL fixes some dependencies in: webrtc/test/fuzzers/BUILD.gn > (PS #2 and PS #3). > > BUG=webrtc:6828 > > Original issue's description: > > Revert of Enabling 'gn check' on //webrtc/test. (patchset #10 id:180001 of https://codereview.webrtc.org/2796363003/ ) > > > > Reason for revert: > > It is breaking a downstream bot. > > > > Original issue's description: > > > Enabling 'gn check' on //webrtc/test. > > > > > > BUG=webrtc:6828 > > > NOTRY=True > > > > > > Review-Url: https://codereview.webrtc.org/2796363003 > > > Cr-Commit-Position: refs/heads/master@{#17689} > > > Committed:b41445858e> > > > TBR=kjellander@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6828 > > > > Review-Url: https://codereview.webrtc.org/2817003002 > > Cr-Commit-Position: refs/heads/master@{#17690} > > Committed:8a24f47bad> > Review-Url: https://codereview.webrtc.org/2815103005 > Cr-Commit-Position: refs/heads/master@{#17758} > Committed:6f27633f47TBR=kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2842533002 Cr-Commit-Position: refs/heads/master@{#17851}
This commit is contained in:
mbonadei
Commit bot
parent
a115a4b0f3
commit
b80ef8c46e
1
.gn
1
.gn
@ -37,7 +37,6 @@ check_targets = [
|
||||
"//webrtc/stats/*",
|
||||
"//webrtc/system_wrappers/*",
|
||||
"//webrtc/tools/*",
|
||||
"//webrtc/test/*",
|
||||
"//webrtc/voice_engine/*",
|
||||
]
|
||||
|
||||
|
||||
@ -53,13 +53,9 @@ rtc_source_set("video_test_common") {
|
||||
}
|
||||
|
||||
deps = [
|
||||
"..:webrtc_common",
|
||||
"../base:rtc_base_approved",
|
||||
"../base:rtc_task_queue",
|
||||
"../common_video",
|
||||
"../media:rtc_media_base",
|
||||
"../modules/video_capture:video_capture_module",
|
||||
"../system_wrappers",
|
||||
]
|
||||
}
|
||||
|
||||
@ -81,7 +77,6 @@ rtc_source_set("rtp_test_utils") {
|
||||
|
||||
deps = [
|
||||
"..:webrtc_common",
|
||||
"../base:rtc_base_approved",
|
||||
"../modules/rtp_rtcp",
|
||||
"//testing/gtest",
|
||||
]
|
||||
@ -112,7 +107,6 @@ rtc_source_set("test_main") {
|
||||
]
|
||||
deps = [
|
||||
":field_trial",
|
||||
"../base:rtc_base_approved",
|
||||
"../system_wrappers:metrics_default",
|
||||
"//testing/gmock",
|
||||
"//testing/gtest",
|
||||
@ -130,16 +124,6 @@ rtc_source_set("fileutils") {
|
||||
sources += [ "testsupport/iosfileutils.mm" ]
|
||||
}
|
||||
visibility = [ ":*" ]
|
||||
deps = [
|
||||
"..:webrtc_common",
|
||||
"../base:rtc_base_approved",
|
||||
]
|
||||
if (is_ios) {
|
||||
deps += [ "../sdk:rtc_sdk_common_objc" ]
|
||||
}
|
||||
if (is_win) {
|
||||
deps += [ "../base:rtc_base" ]
|
||||
}
|
||||
}
|
||||
|
||||
rtc_source_set("video_test_support") {
|
||||
@ -158,9 +142,6 @@ rtc_source_set("video_test_support") {
|
||||
]
|
||||
|
||||
deps = [
|
||||
":test_support",
|
||||
":video_test_common",
|
||||
"..:webrtc_common",
|
||||
"../base:rtc_base_approved",
|
||||
"../common_video",
|
||||
"../system_wrappers",
|
||||
@ -209,7 +190,6 @@ rtc_source_set("test_support") {
|
||||
]
|
||||
|
||||
deps = [
|
||||
"..:webrtc_common",
|
||||
"../base:gtest_prod",
|
||||
"../base:rtc_base_approved",
|
||||
"../common_video",
|
||||
@ -315,20 +295,12 @@ rtc_test("test_support_unittests") {
|
||||
|
||||
deps += [
|
||||
":direct_transport",
|
||||
":fake_audio_device",
|
||||
":fileutils_unittests",
|
||||
":rtp_test_utils",
|
||||
":test_common",
|
||||
":test_main",
|
||||
":video_test_common",
|
||||
":video_test_support",
|
||||
"../api:video_frame_api",
|
||||
"../base:rtc_base_approved",
|
||||
"../call:call_interfaces",
|
||||
"../common_audio",
|
||||
"../modules/rtp_rtcp",
|
||||
"../modules/video_capture",
|
||||
"../system_wrappers",
|
||||
"//testing/gmock",
|
||||
"//testing/gtest",
|
||||
"//third_party/gflags",
|
||||
@ -341,7 +313,6 @@ rtc_source_set("fileutils_unittests") {
|
||||
]
|
||||
deps = [
|
||||
":fileutils",
|
||||
":test_support",
|
||||
"//testing/gmock",
|
||||
"//testing/gtest",
|
||||
]
|
||||
@ -360,12 +331,9 @@ rtc_source_set("direct_transport") {
|
||||
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
||||
}
|
||||
deps = [
|
||||
"..:webrtc_common",
|
||||
"../api:transport_api",
|
||||
"../base:rtc_base_approved",
|
||||
"../call",
|
||||
"../modules/rtp_rtcp",
|
||||
"../system_wrappers",
|
||||
]
|
||||
}
|
||||
|
||||
@ -380,11 +348,8 @@ rtc_source_set("fake_audio_device") {
|
||||
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
|
||||
}
|
||||
deps = [
|
||||
"..:webrtc_common",
|
||||
"../base:rtc_base_approved",
|
||||
"../common_audio",
|
||||
"../modules/audio_device",
|
||||
"../system_wrappers",
|
||||
"../modules/audio_device:audio_device",
|
||||
]
|
||||
}
|
||||
|
||||
@ -437,25 +402,13 @@ rtc_source_set("test_common") {
|
||||
":test_support",
|
||||
":video_test_common",
|
||||
"..:webrtc_common",
|
||||
"../api:transport_api",
|
||||
"../api:video_frame_api",
|
||||
"../api/audio_codecs:builtin_audio_decoder_factory",
|
||||
"../api/video_codecs:video_codecs_api",
|
||||
"../audio",
|
||||
"../base:rtc_base_approved",
|
||||
"../base:rtc_task_queue",
|
||||
"../call",
|
||||
"../logging:rtc_event_log_api",
|
||||
"../modules/audio_device:mock_audio_device",
|
||||
"../modules/audio_mixer:audio_mixer_impl",
|
||||
"../modules/audio_processing",
|
||||
"../modules/rtp_rtcp:rtp_rtcp",
|
||||
"../modules/video_coding:webrtc_h264",
|
||||
"../modules/video_coding:webrtc_vp8",
|
||||
"../modules/video_coding:webrtc_vp9",
|
||||
"../system_wrappers",
|
||||
"../video",
|
||||
"../voice_engine",
|
||||
"//testing/gmock",
|
||||
"//testing/gtest",
|
||||
]
|
||||
@ -531,9 +484,6 @@ rtc_source_set("test_renderer") {
|
||||
|
||||
deps = [
|
||||
":test_support",
|
||||
"..:webrtc_common",
|
||||
"../base:rtc_base_approved",
|
||||
"../common_video",
|
||||
"../modules/media_file",
|
||||
"//testing/gtest",
|
||||
]
|
||||
@ -545,10 +495,4 @@ rtc_source_set("audio_codec_mocks") {
|
||||
"mock_audio_decoder.h",
|
||||
"mock_audio_decoder_factory.h",
|
||||
]
|
||||
deps = [
|
||||
":test_support",
|
||||
"../api/audio_codecs:audio_codecs_api",
|
||||
"../api/audio_codecs:builtin_audio_decoder_factory",
|
||||
"../base:rtc_base_approved",
|
||||
]
|
||||
}
|
||||
|
||||
@ -15,7 +15,6 @@ rtc_static_library("webrtc_fuzzer_main") {
|
||||
"webrtc_fuzzer_main.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../system_wrappers:field_trial_default",
|
||||
"../../system_wrappers:metrics_default",
|
||||
"//testing/libfuzzer:libfuzzer_main",
|
||||
@ -65,7 +64,6 @@ webrtc_fuzzer_test("vp8_qp_parser_fuzzer") {
|
||||
"vp8_qp_parser_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../modules/video_coding:video_coding_utility",
|
||||
"../../modules/video_coding/",
|
||||
]
|
||||
}
|
||||
@ -75,7 +73,6 @@ webrtc_fuzzer_test("h264_bitstream_parser_fuzzer") {
|
||||
"h264_bitstream_parser_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../common_video",
|
||||
"../../modules/video_coding/",
|
||||
]
|
||||
}
|
||||
@ -85,8 +82,7 @@ webrtc_fuzzer_test("flexfec_header_reader_fuzzer") {
|
||||
"flexfec_header_reader_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
}
|
||||
|
||||
@ -95,8 +91,7 @@ webrtc_fuzzer_test("flexfec_sender_fuzzer") {
|
||||
"flexfec_sender_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../system_wrappers",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
libfuzzer_options = [ "max_len=200" ]
|
||||
}
|
||||
@ -106,8 +101,7 @@ webrtc_fuzzer_test("ulpfec_header_reader_fuzzer") {
|
||||
"ulpfec_header_reader_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
}
|
||||
|
||||
@ -116,9 +110,7 @@ webrtc_fuzzer_test("ulpfec_generator_fuzzer") {
|
||||
"ulpfec_generator_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../modules/rtp_rtcp:rtp_rtcp_unittests",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
}
|
||||
|
||||
@ -127,8 +119,7 @@ webrtc_fuzzer_test("flexfec_receiver_fuzzer") {
|
||||
"flexfec_receiver_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
libfuzzer_options = [ "max_len=2000" ]
|
||||
}
|
||||
@ -138,8 +129,7 @@ webrtc_fuzzer_test("packet_buffer_fuzzer") {
|
||||
"packet_buffer_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../modules/video_coding",
|
||||
"../../system_wrappers",
|
||||
"../../modules/video_coding/",
|
||||
]
|
||||
libfuzzer_options = [ "max_len=2000" ]
|
||||
}
|
||||
@ -149,9 +139,7 @@ webrtc_fuzzer_test("rtcp_receiver_fuzzer") {
|
||||
"rtcp_receiver_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../system_wrappers",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
seed_corpus = "corpora/rtcp-corpus"
|
||||
}
|
||||
@ -161,7 +149,7 @@ webrtc_fuzzer_test("rtp_packet_fuzzer") {
|
||||
"rtp_packet_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
seed_corpus = "corpora/rtp-corpus"
|
||||
}
|
||||
@ -171,7 +159,7 @@ webrtc_fuzzer_test("rtp_header_fuzzer") {
|
||||
"rtp_header_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../modules/rtp_rtcp/",
|
||||
]
|
||||
}
|
||||
|
||||
@ -180,11 +168,8 @@ webrtc_fuzzer_test("congestion_controller_feedback_fuzzer") {
|
||||
"congestion_controller_feedback_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../logging:rtc_event_log_api",
|
||||
"../../logging:rtc_event_log_impl",
|
||||
"../../modules/congestion_controller",
|
||||
"../../modules/remote_bitrate_estimator",
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../modules/congestion_controller/",
|
||||
]
|
||||
}
|
||||
|
||||
@ -193,12 +178,6 @@ rtc_static_library("audio_decoder_fuzzer") {
|
||||
"audio_decoder_fuzzer.cc",
|
||||
"audio_decoder_fuzzer.h",
|
||||
]
|
||||
deps = [
|
||||
"../..:webrtc_common",
|
||||
"../../api/audio_codecs:audio_codecs_api",
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/rtp_rtcp",
|
||||
]
|
||||
}
|
||||
|
||||
webrtc_fuzzer_test("audio_decoder_ilbc_fuzzer") {
|
||||
@ -275,10 +254,8 @@ webrtc_fuzzer_test("neteq_rtp_fuzzer") {
|
||||
"neteq_rtp_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/audio_coding:neteq",
|
||||
"../../modules/audio_coding:neteq_test_minimal",
|
||||
"../../modules/audio_coding:neteq_unittest_tools",
|
||||
"../../modules/audio_coding:pcm16b",
|
||||
"../../modules/rtp_rtcp",
|
||||
]
|
||||
@ -321,7 +298,6 @@ webrtc_fuzzer_test("pseudotcp_parser_fuzzer") {
|
||||
"pseudotcp_parser_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base",
|
||||
"../../p2p:rtc_p2p",
|
||||
]
|
||||
}
|
||||
@ -331,7 +307,6 @@ webrtc_fuzzer_test("transport_feedback_packet_loss_tracker_fuzzer") {
|
||||
"transport_feedback_packet_loss_tracker_fuzzer.cc",
|
||||
]
|
||||
deps = [
|
||||
"../../base:rtc_base_approved",
|
||||
"../../modules/rtp_rtcp",
|
||||
"../../voice_engine",
|
||||
]
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user