admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a flaky turnport test failure

Browse Source 
The connection was deleted asynchronously, so need to use EXPECT_TRUE_WAIT.

BUG=
TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1567433002 .

Cr-Commit-Position: refs/heads/master@{#11153}
This commit is contained in:
Honghai Zhang 2016-01-05 13:51:03 -08:00
parent 6b9ab9204b
commit b6802749f1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/p2p/base/turnport_unittest.cc
View File

@ -709,7 +709,7 @@ TEST_F(TurnPortTest, TestRefreshRequestGetsErrorResponse) {
turn_port_->FlushRequests(cricket::TURN_REFRESH_REQUEST);
EXPECT_TRUE_WAIT(!turn_refresh_success_, kTimeout);
EXPECT_TRUE_WAIT(!turn_port_->connected(), kTimeout);
EXPECT_TRUE(turn_port_->connections().empty());
EXPECT_TRUE_WAIT(turn_port_->connections().empty(), kTimeout);
EXPECT_FALSE(turn_port_->HasRequests());
}