From b5a013815f32ed4d7d0cdf6eed84b0a1f751cea7 Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 29 Apr 2020 11:09:59 +0200 Subject: [PATCH] Rename done() into condition(), because it is actually condition in TimeController API Bug: None Change-Id: Ia3a742d1d2ad1238223f4da7ae843a8d22108ec5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174060 Reviewed-by: Sebastian Jansson Commit-Queue: Artem Titov Cr-Commit-Position: refs/heads/master@{#31144} --- api/test/time_controller.cc | 6 +++--- api/test/time_controller.h | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/api/test/time_controller.cc b/api/test/time_controller.cc index f2b1a05c16..364dbc235d 100644 --- a/api/test/time_controller.cc +++ b/api/test/time_controller.cc @@ -26,7 +26,7 @@ std::unique_ptr TimeController::CreateTaskQueueFactory() { }; return std::make_unique(GetTaskQueueFactory()); } -bool TimeController::Wait(const std::function& done, +bool TimeController::Wait(const std::function& condition, TimeDelta max_duration) { // Step size is chosen to be short enough to not significantly affect latency // in real time tests while being long enough to avoid adding too much load to @@ -34,10 +34,10 @@ bool TimeController::Wait(const std::function& done, const auto kStep = TimeDelta::Millis(5); for (auto elapsed = TimeDelta::Zero(); elapsed < max_duration; elapsed += kStep) { - if (done()) + if (condition()) return true; AdvanceTime(kStep); } - return done(); + return condition(); } } // namespace webrtc diff --git a/api/test/time_controller.h b/api/test/time_controller.h index 3276b4fbdd..4d7f9e6c39 100644 --- a/api/test/time_controller.h +++ b/api/test/time_controller.h @@ -57,8 +57,9 @@ class TimeController { // for the given |duration|. virtual void AdvanceTime(TimeDelta duration) = 0; - // Waits until done() == true, polling done() in small time intervals. - bool Wait(const std::function& done, + // Waits until condition() == true, polling condition() in small time + // intervals. + bool Wait(const std::function& condition, TimeDelta max_duration = TimeDelta::Seconds(5)); };