diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc index d873d8b767..47ed43e82e 100644 --- a/webrtc/media/engine/webrtcvoiceengine.cc +++ b/webrtc/media/engine/webrtcvoiceengine.cc @@ -1676,10 +1676,8 @@ bool WebRtcVoiceMediaChannel::SetSendCodecs( } // Set nack status on receive channels. - if (!send_streams_.empty()) { - for (const auto& kv : recv_streams_) { - SetNack(kv.second->channel(), send_codec_spec_.nack_enabled); - } + for (const auto& kv : recv_streams_) { + SetNack(kv.second->channel(), send_codec_spec_.nack_enabled); } // Check if the transport cc feedback has changed on the preferred send codec, diff --git a/webrtc/media/engine/webrtcvoiceengine_unittest.cc b/webrtc/media/engine/webrtcvoiceengine_unittest.cc index 5d8dd90d02..e879cf2d38 100644 --- a/webrtc/media/engine/webrtcvoiceengine_unittest.cc +++ b/webrtc/media/engine/webrtcvoiceengine_unittest.cc @@ -1351,7 +1351,8 @@ TEST_F(WebRtcVoiceEngineTestFake, SetSendCodecEnableNackAsCallee) { cricket::kParamValueEmpty)); EXPECT_FALSE(voe_.GetNACK(channel_num)); EXPECT_TRUE(channel_->SetSendParameters(parameters)); - EXPECT_FALSE(voe_.GetNACK(channel_num)); + // NACK should be enabled even with no send stream. + EXPECT_TRUE(voe_.GetNACK(channel_num)); EXPECT_TRUE(channel_->AddSendStream( cricket::StreamParams::CreateLegacy(kSsrc1)));