From b55bd5fef07f5f07438b3cafa340adb9072a619a Mon Sep 17 00:00:00 2001 From: ehmaldonado Date: Thu, 2 Feb 2017 11:51:21 -0800 Subject: [PATCH] Don't capture variables explicitly in lambda expression. As it is, the test fails to compile on some downstream compilers with the following error: webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc:316:25: error: lambda capture 'kPayloadLength' is not required to be captured for this use [-Werror,-Wunused-lambda-capture] .WillOnce(Invoke([kPayloadLength, kFirstSequenceNumber, kFirstTimestamp, ^ webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc:316:41: error: lambda capture 'kFirstSequenceNumber' is not required to be captured for this use [-Werror,-Wunused-lambda-capture] .WillOnce(Invoke([kPayloadLength, kFirstSequenceNumber, kFirstTimestamp, ^ webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc:316:63: error: lambda capture 'kFirstTimestamp' is not required to be captured for this use [-Werror,-Wunused-lambda-capture] .WillOnce(Invoke([kPayloadLength, kFirstSequenceNumber, kFirstTimestamp, ^ webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc:317:25: error: lambda capture 'kFirstReceiveTime' is not required to be captured for this use [-Werror,-Wunused-lambda-capture] kFirstReceiveTime](const SdpAudioFormat& format, BUG=webrtc:7107 Review-Url: https://codereview.webrtc.org/2672823002 Cr-Commit-Position: refs/heads/master@{#16422} --- webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc index 71893e5017..1c93543e2d 100644 --- a/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc +++ b/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc @@ -313,9 +313,8 @@ TEST_F(NetEqImplTest, InsertPacket) { rtc::scoped_refptr mock_decoder_factory( new rtc::RefCountedObject); EXPECT_CALL(*mock_decoder_factory, MakeAudioDecoderMock(_, _)) - .WillOnce(Invoke([kPayloadLength, kFirstSequenceNumber, kFirstTimestamp, - kFirstReceiveTime](const SdpAudioFormat& format, - std::unique_ptr* dec) { + .WillOnce(Invoke([&](const SdpAudioFormat& format, + std::unique_ptr* dec) { EXPECT_EQ("pcmu", format.name); std::unique_ptr mock_decoder(new MockAudioDecoder);