Delete unneeded dependencies on libjingle_peerconnection_api

Also annotate a few of the remaining uses, to guide further splits of
that large build target.

Bug: webrtc:8733
Change-Id: I16ac33ab48e6d39a1a8dbc2a3fc671d8db6dbfe9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150789
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29001}

api/BUILD.gn

@@ -291,6 +291,7 @@ rtc_source_set("stats_observer_interface") {
   ]
 
   deps = [
+    # For api/stats_types.h
     ":libjingle_peerconnection_api",
     ":rtp_parameters",
   ]
@@ -690,6 +691,7 @@ if (rtc_include_tests) {
       "test/mock_frame_encryptor.h",
     ]
     deps = [
+      # For api/crypto/frame_encryptor_interface.h
       ":libjingle_peerconnection_api",
       "../test:test_support",
     ]

api/video/BUILD.gn

@@ -226,12 +226,10 @@ rtc_source_set("video_stream_encoder") {
     ":video_bitrate_allocator",
     ":video_bitrate_allocator_factory",
     ":video_frame",
+    "..:rtp_parameters",
     "../:fec_controller_api",
     "../:rtp_parameters",
     "../units:data_rate",
-
-    # For rtpparameters.h
-    "..:libjingle_peerconnection_api",
     "../video_codecs:video_codecs_api",
     "//third_party/abseil-cpp/absl/types:optional",
   ]

audio/BUILD.gn

@@ -41,6 +41,8 @@ rtc_static_library("audio") {
     "../api:array_view",
     "../api:call_api",
     "../api:function_view",
+
+    # For api/crypto/crypto_options.h
     "../api:libjingle_peerconnection_api",
     "../api:rtp_headers",
     "../api:rtp_parameters",

call/BUILD.gn

@@ -31,6 +31,8 @@ rtc_source_set("call_interfaces") {
     ":rtp_interfaces",
     ":video_stream_api",
     "../api:fec_controller_api",
+
+    # For api/media_transport_config.h
     "../api:libjingle_peerconnection_api",
     "../api:network_state_predictor_api",
     "../api:rtp_headers",
@@ -75,6 +77,8 @@ rtc_source_set("rtp_interfaces") {
   deps = [
     "../api:array_view",
     "../api:fec_controller_api",
+
+    # For api/crypto/crypto_options.h
     "../api:libjingle_peerconnection_api",
     "../api:rtp_headers",
     "../api:rtp_parameters",
@@ -176,6 +180,8 @@ rtc_source_set("bitrate_configurator") {
   ]
   deps = [
     ":rtp_interfaces",
+
+    # For api/bitrate_constraints.h
     "../api:libjingle_peerconnection_api",
     "../api/transport:bitrate_settings",
     "../rtc_base:checks",
@@ -227,7 +233,6 @@ rtc_static_library("call") {
     "../api:array_view",
     "../api:callfactory_api",
     "../api:fec_controller_api",
-    "../api:libjingle_peerconnection_api",
     "../api:rtp_headers",
     "../api:rtp_parameters",
     "../api:simulated_network_api",
@@ -372,7 +377,6 @@ if (rtc_include_tests) {
       "../api:array_view",
       "../api:fake_media_transport",
       "../api:fake_media_transport",
-      "../api:libjingle_peerconnection_api",
       "../api:mock_audio_mixer",
       "../api:rtp_headers",
       "../api:rtp_parameters",

logging/BUILD.gn

@@ -51,7 +51,6 @@ rtc_source_set("rtc_stream_config") {
 
   deps = [
     ":rtc_event_log_api",
-    "../api:libjingle_peerconnection_api",
     "../api:rtp_headers",
     "../api:rtp_parameters",
   ]
@@ -401,7 +400,6 @@ if (rtc_enable_protobuf) {
       deps = [
         ":rtc_event_log_parser",
         "../api:array_view",
-        "../api:libjingle_peerconnection_api",
         "../api:rtp_headers",
         "../api/rtc_event_log",
         "../modules/rtp_rtcp",
@@ -437,6 +435,8 @@ rtc_source_set("ice_log") {
   deps = [
     ":rtc_event_log_api",
     "../api:libjingle_logging_api",
+
+    # For api/dtls_transport_interface.h
     "../api:libjingle_peerconnection_api",
     "../api/rtc_event_log",
     "../rtc_base:rtc_base_approved",

media/BUILD.gn

@@ -425,7 +425,6 @@ if (rtc_include_tests) {
       ":rtc_simulcast_encoder_adapter",
       "../api:call_api",
       "../api:fec_controller_api",
-      "../api:libjingle_peerconnection_api",
       "../api:scoped_refptr",
       "../api/video:encoded_image",
       "../api/video:video_bitrate_allocation",

test/BUILD.gn

@@ -53,7 +53,6 @@ rtc_source_set("video_test_common") {
 
   deps = [
     ":fileutils",
-    "../api:libjingle_peerconnection_api",
     "../api:scoped_refptr",
     "../api/task_queue",
     "../api/video:video_frame",
@@ -735,7 +734,6 @@ rtc_source_set("test_common") {
     ":rtp_test_utils",
     ":test_support",
     ":video_test_common",
-    "../api:libjingle_peerconnection_api",
     "../api:rtp_headers",
     "../api:rtp_parameters",
     "../api:scoped_refptr",