admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enabling clang::find_bad_constructs for modules/pacing.

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I118156a4f9b00d8c4c4f199a5af50c494e31c34a
Reviewed-on: https://webrtc-review.googlesource.com/89343
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24020}
This commit is contained in:
Mirko Bonadei 2018-07-18 14:11:27 +02:00 committed by Commit Bot
parent 06f66c7260
commit b471c905a4
5 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/pacing/BUILD.gn
View File

@ -25,11 +25,6 @@ rtc_static_library("pacing") {
"round_robin_packet_queue.h",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
":interval_budget",
"..:module_api",
@ -60,11 +55,6 @@ rtc_source_set("interval_budget") {
"interval_budget.h",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [
# "../../:typedefs",
"../../:webrtc_common",
@ -99,11 +89,6 @@ if (rtc_include_tests) {
"../rtp_rtcp:mock_rtp_rtcp",
"../rtp_rtcp:rtp_rtcp_format",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
}
rtc_source_set("mock_paced_sender") {

2
modules/pacing/bitrate_prober.cc
View File

@ -47,6 +47,8 @@ constexpr int64_t kProbeClusterTimeoutMs = 5000;
BitrateProber::BitrateProber() : BitrateProber(nullptr) {}
BitrateProber::~BitrateProber() = default;
BitrateProber::BitrateProber(RtcEventLog* event_log)
: probing_state_(ProbingState::kDisabled),
next_probe_time_ms_(-1),

1
modules/pacing/bitrate_prober.h
View File

@ -25,6 +25,7 @@ class BitrateProber {
public:
BitrateProber();
explicit BitrateProber(RtcEventLog* event_log);
~BitrateProber();
void SetEnabled(bool enable);

1
modules/pacing/round_robin_packet_queue.cc
View File

@ -18,6 +18,7 @@
namespace webrtc {
RoundRobinPacketQueue::Stream::Stream() : bytes(0) {}
RoundRobinPacketQueue::Stream::Stream(const Stream& stream) = default;
RoundRobinPacketQueue::Stream::~Stream() {}
RoundRobinPacketQueue::RoundRobinPacketQueue(const Clock* clock)

1
modules/pacing/round_robin_packet_queue.h
View File

@ -59,6 +59,7 @@ class RoundRobinPacketQueue : public PacketQueueInterface {
struct Stream {
Stream();
Stream(const Stream&);
virtual ~Stream();