admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove sigslot inheritance from Connection

Browse Source 
...and add to TCPConnection as it's still needed there.

Bug: webrtc:11943
Change-Id: Id66b890677d7e0b03a4a700414f574abd6e3af58
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260320
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36689}
This commit is contained in:
Tommi 2022-04-28 12:31:47 +02:00 committed by WebRTC LUCI CQ
parent 69edcaf47b
commit b44a794bd3
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
p2p/base/connection.h
View File

@ -71,7 +71,7 @@ class ConnectionRequest : public StunRequest {
// Represents a communication link between a port on the local client and a
// port on the remote client.
class Connection : public CandidatePairInterface, public sigslot::has_slots<> {
class Connection : public CandidatePairInterface {
public:
struct SentPing {
SentPing(const std::string id, int64_t sent_time, uint32_t nomination)

2
p2p/base/stun_request_unittest.cc
View File

@ -39,7 +39,7 @@ int TotalDelay(int sends) {
}
} // namespace
class StunRequestTest : public ::testing::Test, public sigslot::has_slots<> {
class StunRequestTest : public ::testing::Test {
public:
StunRequestTest()
: manager_(rtc::Thread::Current(),

2
p2p/base/tcp_port.h
View File

@ -124,7 +124,7 @@ class TCPPort : public Port {
friend class TCPConnection;
};
class TCPConnection : public Connection {
class TCPConnection : public Connection, public sigslot::has_slots<> {
public:
// Connection is outgoing unless socket is specified
TCPConnection(rtc::WeakPtr<Port> tcp_port,