From b3cc78de2823300b0dab3555fc57e0d52ad7913b Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Thu, 21 Nov 2013 11:42:02 +0000 Subject: [PATCH] Add -Wnon-virtual-dtor warning for C++ code. BUG=2659 R=kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/4119006 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5149 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/build/common.gypi | 1 + webrtc/test/rtp_rtcp_observer.h | 1 + 2 files changed, 2 insertions(+) diff --git a/webrtc/build/common.gypi b/webrtc/build/common.gypi index 73608a47bb..0c47315d49 100644 --- a/webrtc/build/common.gypi +++ b/webrtc/build/common.gypi @@ -183,6 +183,7 @@ '-Wno-missing-field-initializers', ], 'cflags_cc': [ + '-Wnon-virtual-dtor', # This is enabled for clang; enable for gcc as well. '-Woverloaded-virtual', ], diff --git a/webrtc/test/rtp_rtcp_observer.h b/webrtc/test/rtp_rtcp_observer.h index 652421489d..f82d27b766 100644 --- a/webrtc/test/rtp_rtcp_observer.h +++ b/webrtc/test/rtp_rtcp_observer.h @@ -22,6 +22,7 @@ namespace test { class RtpRtcpObserver { public: + virtual ~RtpRtcpObserver() {} newapi::Transport* SendTransport() { return &send_transport_; }