From b2b6cd3af9449cfb647d52d85faec193c2436485 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sami=20Kalliom=C3=A4ki?= Date: Mon, 27 Jul 2020 15:50:07 +0200 Subject: [PATCH] Delete dead code from JNI audio header. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:9048 Change-Id: I912a50f84a3afbb7cd13357ba8b134323fd53ed9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180343 Commit-Queue: Sami Kalliomäki Reviewed-by: Kári Helgason Cr-Commit-Position: refs/heads/master@{#31797} --- sdk/android/BUILD.gn | 2 -- sdk/android/src/jni/pc/audio.cc | 10 ---------- sdk/android/src/jni/pc/audio.h | 8 +------- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/sdk/android/BUILD.gn b/sdk/android/BUILD.gn index 4506cbdbf3..de91306386 100644 --- a/sdk/android/BUILD.gn +++ b/sdk/android/BUILD.gn @@ -570,8 +570,6 @@ if (current_os == "linux" || is_android) { deps = [ ":base_jni", ":builtin_audio_codecs_jni", - "../../api/audio_codecs:builtin_audio_decoder_factory", - "../../api/audio_codecs:builtin_audio_encoder_factory", "../../modules/audio_processing", "../../modules/audio_processing:api", "../../rtc_base:rtc_base_approved", diff --git a/sdk/android/src/jni/pc/audio.cc b/sdk/android/src/jni/pc/audio.cc index 376c42178a..74c8b5547a 100644 --- a/sdk/android/src/jni/pc/audio.cc +++ b/sdk/android/src/jni/pc/audio.cc @@ -10,21 +10,11 @@ #include "sdk/android/src/jni/pc/audio.h" -#include "api/audio_codecs/builtin_audio_decoder_factory.h" -#include "api/audio_codecs/builtin_audio_encoder_factory.h" #include "modules/audio_processing/include/audio_processing.h" namespace webrtc { namespace jni { -rtc::scoped_refptr CreateAudioDecoderFactory() { - return CreateBuiltinAudioDecoderFactory(); -} - -rtc::scoped_refptr CreateAudioEncoderFactory() { - return CreateBuiltinAudioEncoderFactory(); -} - rtc::scoped_refptr CreateAudioProcessing() { return AudioProcessingBuilder().Create(); } diff --git a/sdk/android/src/jni/pc/audio.h b/sdk/android/src/jni/pc/audio.h index 1e8b3accc2..7a79bed986 100644 --- a/sdk/android/src/jni/pc/audio.h +++ b/sdk/android/src/jni/pc/audio.h @@ -11,20 +11,14 @@ #ifndef SDK_ANDROID_SRC_JNI_PC_AUDIO_H_ #define SDK_ANDROID_SRC_JNI_PC_AUDIO_H_ +#include "api/scoped_refptr.h" // Adding 'nogncheck' to disable the gn include headers check. // We don't want this target depend on audio related targets -#include "api/audio_codecs/audio_decoder_factory.h" // nogncheck -#include "api/audio_codecs/audio_encoder_factory.h" // nogncheck -#include "api/scoped_refptr.h" #include "modules/audio_processing/include/audio_processing.h" // nogncheck namespace webrtc { namespace jni { -rtc::scoped_refptr CreateAudioDecoderFactory(); - -rtc::scoped_refptr CreateAudioEncoderFactory(); - rtc::scoped_refptr CreateAudioProcessing(); } // namespace jni