From b08290b3c51b98170cae4049b985ef1b1d9f37d1 Mon Sep 17 00:00:00 2001 From: Yura Yaroshevich Date: Fri, 22 Oct 2021 13:59:17 +0200 Subject: [PATCH] Request DTMF sender only for audio sender in iOS SDK. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Error message "Tried to get DTMF sender from video sender." should no longer pollute logs. Bug: None Change-Id: I60d6f45ba049e93ec06d645da43fb8269354edf3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235982 Reviewed-by: Kári Helgason Commit-Queue: Yura Yaroshevich Cr-Commit-Position: refs/heads/main@{#35322} --- sdk/objc/api/peerconnection/RTCRtpSender.mm | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sdk/objc/api/peerconnection/RTCRtpSender.mm b/sdk/objc/api/peerconnection/RTCRtpSender.mm index 1ca9360ab8..12566ecf6f 100644 --- a/sdk/objc/api/peerconnection/RTCRtpSender.mm +++ b/sdk/objc/api/peerconnection/RTCRtpSender.mm @@ -116,11 +116,13 @@ if (self = [super init]) { _factory = factory; _nativeRtpSender = nativeRtpSender; - rtc::scoped_refptr nativeDtmfSender( - _nativeRtpSender->GetDtmfSender()); - if (nativeDtmfSender) { - _dtmfSender = - [[RTC_OBJC_TYPE(RTCDtmfSender) alloc] initWithNativeDtmfSender:nativeDtmfSender]; + if (_nativeRtpSender->media_type() == cricket::MEDIA_TYPE_AUDIO) { + rtc::scoped_refptr nativeDtmfSender( + _nativeRtpSender->GetDtmfSender()); + if (nativeDtmfSender) { + _dtmfSender = + [[RTC_OBJC_TYPE(RTCDtmfSender) alloc] initWithNativeDtmfSender:nativeDtmfSender]; + } } RTCLogInfo(@"RTC_OBJC_TYPE(RTCRtpSender)(%p): created sender: %@", self, self.description); }