From b073f1c27fa5c8ae8ea5f125f0cdef254379a4ab Mon Sep 17 00:00:00 2001 From: Bjorn A Mellem Date: Tue, 2 Jul 2019 09:50:35 -0700 Subject: [PATCH] Only set the RtcEventLog for media transport when it's used for media. Currently, GenerateOrGetLastMediaTransportOffer() creates a media transport that has an RtcEventLog, regardless of whether the media transport is used for media or data channels. It should only set the RtcEventLog when used for media. Bug: webrtc:10789 Change-Id: Id91c16973deec89bbc8c6518c4c9f1039f1265fc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144367 Commit-Queue: Bjorn Mellem Commit-Queue: Steve Anton Reviewed-by: Peter Slatala Reviewed-by: Steve Anton Cr-Commit-Position: refs/heads/master@{#28450} --- pc/jsep_transport_controller.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pc/jsep_transport_controller.cc b/pc/jsep_transport_controller.cc index 597ab4a1db..e3ae2bac0c 100644 --- a/pc/jsep_transport_controller.cc +++ b/pc/jsep_transport_controller.cc @@ -1677,7 +1677,9 @@ JsepTransportController::GenerateOrGetLastMediaTransportOffer() { webrtc::MediaTransportSettings settings; settings.is_caller = true; settings.pre_shared_key = rtc::CreateRandomString(32); - settings.event_log = config_.event_log; + if (config_.use_media_transport_for_media) { + settings.event_log = config_.event_log; + } auto media_transport_or_error = config_.media_transport_factory->CreateMediaTransport(network_thread_, settings);