admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Greatly reduce number of level controller tests.

Browse Source 
These tests have been causing a large number of false alerts, which is
tons of work for the perf sheriff. It's infeasible to test every single
permutation, so we must choose carefully. This CL reduces the number
of RESULT lines from the test from ~450 to ~50. I attempted to choose
interesting permutations, but you probably know better what's
interesting...

https://chromeperf.appspot.com/report?
sid=a7193c96f708018848ca07ad9c78ac657cadab3c70b3939c42bd7d70a092d61a
also suggests most of the metrics have enormous standard deviations,
so maybe you could look into how stable the metrics really are
and remove/stabilize the ones that aren't?

BUG=chromium:666725

Review-Url: https://codereview.webrtc.org/2529393006
Cr-Commit-Position: refs/heads/master@{#15329}
This commit is contained in:
phoglund 2016-11-30 05:04:39 -08:00 committed by Commit bot
parent 6a2e20ad14
commit aff96361d3
1 changed files with 34 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc
View File

@ -184,25 +184,40 @@ TEST(LevelControllerPerformanceTest, StandaloneProcessing) {
}
}
void TestSomeSampleRatesWithApm(const std::string& test_name,
bool use_mobile_agc,
bool include_default_apm_processing) {
// Test some stereo combinations first.
size_t num_channels = 2;
RunTogetherWithApm(test_name, 48000, 48000, AudioProcessing::kSampleRate8kHz,
AudioProcessing::kSampleRate48kHz, num_channels,
use_mobile_agc, include_default_apm_processing);
RunTogetherWithApm(test_name, 48000, 48000, AudioProcessing::kSampleRate16kHz,
AudioProcessing::kSampleRate32kHz, num_channels,
use_mobile_agc, include_default_apm_processing);
RunTogetherWithApm(test_name, 48000, 48000, AudioProcessing::kSampleRate32kHz,
AudioProcessing::kSampleRate16kHz, num_channels,
use_mobile_agc, include_default_apm_processing);
RunTogetherWithApm(test_name, 48000, 48000, AudioProcessing::kSampleRate48kHz,
AudioProcessing::kSampleRate8kHz, num_channels,
use_mobile_agc, include_default_apm_processing);
RunTogetherWithApm(test_name, 48000, 48000, 44100, 44100, num_channels,
use_mobile_agc, include_default_apm_processing);
// Then test mono combinations.
num_channels = 1;
RunTogetherWithApm(test_name, 48000, 48000, AudioProcessing::kSampleRate48kHz,
AudioProcessing::kSampleRate48kHz, num_channels,
use_mobile_agc, include_default_apm_processing);
}
#if !defined(WEBRTC_ANDROID)
TEST(LevelControllerPerformanceTest, ProcessingViaApm) {
#else
TEST(LevelControllerPerformanceTest, DISABLED_ProcessingViaApm) {
#endif
int sample_rates_to_test[] = {AudioProcessing::kSampleRate8kHz,
AudioProcessing::kSampleRate16kHz,
AudioProcessing::kSampleRate32kHz,
AudioProcessing::kSampleRate48kHz, 44100};
for (auto capture_input_sample_rate_hz : sample_rates_to_test) {
for (auto capture_output_sample_rate_hz : sample_rates_to_test) {
for (size_t num_channels = 1; num_channels <= 2; ++num_channels) {
RunTogetherWithApm("SimpleLevelControlViaApm", 48000, 48000,
capture_input_sample_rate_hz,
capture_output_sample_rate_hz, num_channels, false,
false);
}
}
}
// Run without default APM processing and desktop AGC.
TestSomeSampleRatesWithApm("SimpleLevelControlViaApm", false, false);
}
#if !defined(WEBRTC_ANDROID)
@ -210,24 +225,11 @@ TEST(LevelControllerPerformanceTest, InteractionWithDefaultApm) {
#else
TEST(LevelControllerPerformanceTest, DISABLED_InteractionWithDefaultApm) {
#endif
int sample_rates_to_test[] = {AudioProcessing::kSampleRate8kHz,
AudioProcessing::kSampleRate16kHz,
AudioProcessing::kSampleRate32kHz,
AudioProcessing::kSampleRate48kHz, 44100};
for (auto capture_input_sample_rate_hz : sample_rates_to_test) {
for (auto capture_output_sample_rate_hz : sample_rates_to_test) {
for (size_t num_channels = 1; num_channels <= 2; ++num_channels) {
RunTogetherWithApm("LevelControlAndDefaultDesktopApm", 48000, 48000,
capture_input_sample_rate_hz,
capture_output_sample_rate_hz, num_channels, false,
true);
RunTogetherWithApm("LevelControlAndDefaultMobileApm", 48000, 48000,
capture_input_sample_rate_hz,
capture_output_sample_rate_hz, num_channels, true,
true);
}
}
}
bool include_default_apm_processing = true;
TestSomeSampleRatesWithApm("LevelControlAndDefaultDesktopApm", false,
include_default_apm_processing);
TestSomeSampleRatesWithApm("LevelControlAndDefaultMobileApm", true,
include_default_apm_processing);
}
} // namespace webrtc