admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

audio: make packets lost a signed integer

Browse Source 
as it is defined in RFC 3550. This avoids implicit casts
between signed and unsigned definitions.

BUG=webrtc:8626

Change-Id: I919b7c38ede1aa8d32f8e31b55660f540e5f5a6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279240
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#38522}
This commit is contained in:
Philipp Hancke 2022-10-14 09:32:58 +02:00 committed by WebRTC LUCI CQ
parent 1cb3cdece5
commit af512281b1
4 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
audio/channel_receive.h
View File

@ -51,7 +51,7 @@ class RtpPacketReceived;
class RtpRtcp; class RtpRtcp;
struct CallReceiveStatistics { struct CallReceiveStatistics {
unsigned int cumulativeLost; int cumulativeLost;
unsigned int jitterSamples; unsigned int jitterSamples;
int64_t payload_bytes_rcvd = 0; int64_t payload_bytes_rcvd = 0;
int64_t header_and_padding_bytes_rcvd = 0; int64_t header_and_padding_bytes_rcvd = 0;

2
audio/test/audio_stats_test.cc
View File

@ -68,7 +68,7 @@ class NoLossTest : public AudioEndToEndTest {
receive_stream()->GetStats(/*get_and_clear_legacy_stats=*/true); receive_stream()->GetStats(/*get_and_clear_legacy_stats=*/true);
EXPECT_PRED2(IsNear, kBytesSent, recv_stats.payload_bytes_rcvd); EXPECT_PRED2(IsNear, kBytesSent, recv_stats.payload_bytes_rcvd);
EXPECT_PRED2(IsNear, kPacketsSent, recv_stats.packets_rcvd); EXPECT_PRED2(IsNear, kPacketsSent, recv_stats.packets_rcvd);
EXPECT_EQ(0u, recv_stats.packets_lost); EXPECT_EQ(0, recv_stats.packets_lost);
EXPECT_EQ("opus", send_stats.codec_name); EXPECT_EQ("opus", send_stats.codec_name);
// recv_stats.jitter_ms // recv_stats.jitter_ms
// recv_stats.jitter_buffer_ms // recv_stats.jitter_buffer_ms

2
call/audio_receive_stream.h
View File

@ -38,7 +38,7 @@ class AudioReceiveStreamInterface : public MediaReceiveStreamInterface {
uint32_t packets_rcvd = 0; uint32_t packets_rcvd = 0;
uint64_t fec_packets_received = 0; uint64_t fec_packets_received = 0;
uint64_t fec_packets_discarded = 0; uint64_t fec_packets_discarded = 0;
uint32_t packets_lost = 0; int32_t packets_lost = 0;
uint64_t packets_discarded = 0; uint64_t packets_discarded = 0;
uint32_t nacks_sent = 0; uint32_t nacks_sent = 0;
std::string codec_name; std::string codec_name;

3
media/engine/webrtc_voice_engine_unittest.cc
View File

@ -707,8 +707,7 @@ class WebRtcVoiceEngineTestFake : public ::testing::TestWithParam<bool> {
stats.header_and_padding_bytes_rcvd); stats.header_and_padding_bytes_rcvd);
EXPECT_EQ(rtc::checked_cast<unsigned int>(info.packets_rcvd), EXPECT_EQ(rtc::checked_cast<unsigned int>(info.packets_rcvd),
stats.packets_rcvd); stats.packets_rcvd);
EXPECT_EQ(rtc::checked_cast<unsigned int>(info.packets_lost), EXPECT_EQ(info.packets_lost, stats.packets_lost);
stats.packets_lost);
EXPECT_EQ(info.codec_name, stats.codec_name); EXPECT_EQ(info.codec_name, stats.codec_name);
EXPECT_EQ(info.codec_payload_type, stats.codec_payload_type); EXPECT_EQ(info.codec_payload_type, stats.codec_payload_type);
EXPECT_EQ(rtc::checked_cast<unsigned int>(info.jitter_ms), stats.jitter_ms); EXPECT_EQ(rtc::checked_cast<unsigned int>(info.jitter_ms), stats.jitter_ms);