From ad68affb90c2f36246fe7c77767c223620d42584 Mon Sep 17 00:00:00 2001 From: Rasmus Brandt Date: Tue, 4 Oct 2022 21:48:26 +0200 Subject: [PATCH] PacingController: remove unused `kDefaultPaceMultiplier` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: None Change-Id: Ida1fa3b8cde7a9c3694095c1d56aca5832498850 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278040 Reviewed-by: Erik Språng Commit-Queue: Rasmus Brandt Cr-Commit-Position: refs/heads/main@{#38299} --- modules/pacing/pacing_controller.cc | 1 - modules/pacing/pacing_controller.h | 6 ------ 2 files changed, 7 deletions(-) diff --git a/modules/pacing/pacing_controller.cc b/modules/pacing/pacing_controller.cc index 125db84923..a926e32545 100644 --- a/modules/pacing/pacing_controller.cc +++ b/modules/pacing/pacing_controller.cc @@ -47,7 +47,6 @@ bool IsEnabled(const FieldTrialsView& field_trials, absl::string_view key) { const TimeDelta PacingController::kMaxExpectedQueueLength = TimeDelta::Millis(2000); -const float PacingController::kDefaultPaceMultiplier = 2.5f; const TimeDelta PacingController::kPausedProcessInterval = kCongestedPacketInterval; const TimeDelta PacingController::kMinSleepTime = TimeDelta::Millis(1); diff --git a/modules/pacing/pacing_controller.h b/modules/pacing/pacing_controller.h index 988fe50536..94d2402de6 100644 --- a/modules/pacing/pacing_controller.h +++ b/modules/pacing/pacing_controller.h @@ -68,12 +68,6 @@ class PacingController { // encoding them). Bitrate sent may temporarily exceed target set by // UpdateBitrate() so that this limit will be upheld. static const TimeDelta kMaxExpectedQueueLength; - // Pacing-rate relative to our target send rate. - // Multiplicative factor that is applied to the target bitrate to calculate - // the number of bytes that can be transmitted per interval. - // Increasing this factor will result in lower delays in cases of bitrate - // overshoots from the encoder. - static const float kDefaultPaceMultiplier; // If no media or paused, wake up at least every `kPausedProcessIntervalMs` in // order to send a keep-alive packet so we don't get stuck in a bad state due // to lack of feedback.