admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove orphis from OWNERS files

Browse Source 
also fix a few TODOs

Bug: None
Change-Id: I2d287ed1a58f71ef32d5dc5624879ae8c63348b5
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370122
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43485}
This commit is contained in:
Harald Alvestrand 2024-12-03 13:24:22 +00:00 committed by WebRTC LUCI CQ
parent 07d7ca0352
commit ad63489c58
5 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
media/OWNERS
View File

@ -8,6 +8,3 @@ perkj@webrtc.org
# Audio-related changes: # Audio-related changes:
peah@webrtc.org peah@webrtc.org
saza@webrtc.org saza@webrtc.org
# Datachannel-related changes:
orphis@webrtc.org

2
media/engine/webrtc_video_engine.cc
View File

@ -1430,7 +1430,7 @@ webrtc::RTCError WebRtcVideoSendChannel::SetRtpSendParameters(
// Since we validate that all layers have the same value, we can just check // Since we validate that all layers have the same value, we can just check
// the first layer. // the first layer.
// TODO(orphis): Support mixed-codec simulcast // TODO: https://issues.webrtc.org/362277533 - Support mixed-codec simulcast
if (parameters.encodings[0].codec && send_codec_ && if (parameters.encodings[0].codec && send_codec_ &&
!IsSameRtpCodec(send_codec_->codec, *parameters.encodings[0].codec)) { !IsSameRtpCodec(send_codec_->codec, *parameters.encodings[0].codec)) {
RTC_LOG(LS_VERBOSE) << "Trying to change codec to " RTC_LOG(LS_VERBOSE) << "Trying to change codec to "

2
media/engine/webrtc_voice_engine.cc
View File

@ -1926,7 +1926,7 @@ webrtc::RTCError WebRtcVoiceSendChannel::SetRtpSendParameters(
std::optional<cricket::Codec> send_codec = GetSendCodec(); std::optional<cricket::Codec> send_codec = GetSendCodec();
// Since we validate that all layers have the same value, we can just check // Since we validate that all layers have the same value, we can just check
// the first layer. // the first layer.
// TODO(orphis): Support mixed-codec simulcast // TODO: https://issues.webrtc.org/362277533 - Support mixed-codec simulcast
if (parameters.encodings[0].codec && send_codec && if (parameters.encodings[0].codec && send_codec &&
!send_codec->MatchesRtpCodec(*parameters.encodings[0].codec)) { !send_codec->MatchesRtpCodec(*parameters.encodings[0].codec)) {
RTC_LOG(LS_VERBOSE) << "Trying to change codec to " RTC_LOG(LS_VERBOSE) << "Trying to change codec to "

1
media/sctp/OWNERS
View File

@ -1,3 +1,2 @@
boivie@webrtc.org boivie@webrtc.org
deadbeef@webrtc.org deadbeef@webrtc.org
orphis@webrtc.org

1
pc/OWNERS
View File

@ -3,7 +3,6 @@ hta@webrtc.org
perkj@webrtc.org perkj@webrtc.org
tommi@webrtc.org tommi@webrtc.org
deadbeef@webrtc.org deadbeef@webrtc.org
orphis@webrtc.org
# Adding features via SDP munging requires approval from SDP owners # Adding features via SDP munging requires approval from SDP owners
per-file webrtc_sdp.cc = set noparent per-file webrtc_sdp.cc = set noparent