admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use the Process method of vcm::VideoReceiver

Browse Source 
It's used for driving the old jitter buffer, which is used only when
vcm::VideoReceiver is used via the legacy VideoCodingModule api.

Bug: webrtc:7408
Change-Id: I179d5b26e112d9f94615d2e1b410b51a657aa05b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127294
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27147}
This commit is contained in:
Niels Möller 2019-03-14 11:20:30 +01:00 committed by Commit Bot
parent 7bf8c7f8cc
commit ad31c98576
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/testsupport/perf_test.cc
View File

@ -46,7 +46,9 @@ class PerfResultsLogger {
const double value,
const std::string& units,
const bool important) {
RTC_CHECK(std::isfinite(value));
RTC_CHECK(std::isfinite(value))
<< "Expected finite value for graph " << graph_name << ", trace name "
<< trace_name << ", units " << units << ", got " << value;
std::ostringstream value_stream;
value_stream.precision(8);

5
video/video_receive_stream.cc
View File

@ -375,7 +375,9 @@ void VideoReceiveStream::Start() {
// |video_stream_decoder_|.
call_stats_->RegisterStatsObserver(this);
process_thread_->RegisterModule(&video_receiver_, RTC_FROM_HERE);
// NOTE: *Not* registering video_receiver_ on process_thread_. Its Process
// method does nothing that is useful for us, since we no longer use the old
// jitter buffer.
// Start the decode thread
video_receiver_.DecoderThreadStarting();
@ -393,7 +395,6 @@ void VideoReceiveStream::Stop() {
frame_buffer_->Stop();
call_stats_->DeregisterStatsObserver(this);
process_thread_->DeRegisterModule(&video_receiver_);
if (decode_thread_.IsRunning()) {
// TriggerDecoderShutdown will release any waiting decoder thread and make