From acc54b41dafe8f851c07a4022aea114e94cce975 Mon Sep 17 00:00:00 2001 From: "phoglund@webrtc.org" Date: Mon, 7 Jan 2013 12:05:53 +0000 Subject: [PATCH] Added perf expectations and corrected existing tests to remove spaces from series names. The make_expectations.py script is copied from Chrome. It can look at a test's result history and automagically compute good regress/improve values. This patch comes into play together with https://chromereviews.googleplex.com/6242014/. NOTE TO SELF: save history on master when deploying! Review URL: https://webrtc-codereview.appspot.com/1019005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@3339 4adac7df-926f-26a2-2b94-8c16560cd09d --- tools/e2e_quality/audio/run_audio_test.py | 2 +- tools/perf_expectations/README | 1 + tools/perf_expectations/perf_expectations.json | 3 +++ tools/perf_expectations/webrtc_perf_expectations.cfg | 4 ++++ 4 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 tools/perf_expectations/README create mode 100644 tools/perf_expectations/perf_expectations.json create mode 100644 tools/perf_expectations/webrtc_perf_expectations.cfg diff --git a/tools/e2e_quality/audio/run_audio_test.py b/tools/e2e_quality/audio/run_audio_test.py index da780144fe..ae1b09c524 100755 --- a/tools/e2e_quality/audio/run_audio_test.py +++ b/tools/e2e_quality/audio/run_audio_test.py @@ -122,7 +122,7 @@ def main(argv): value = ''.join(re.findall(options.regexp, output)) perf.perf_utils.PrintPerfResult(graph_name='audio_e2e_score', - series_name='e2e score', + series_name='e2e_score', data_point=value, units='MOS') # Assuming we run PESQ. diff --git a/tools/perf_expectations/README b/tools/perf_expectations/README new file mode 100644 index 0000000000..87c6087e84 --- /dev/null +++ b/tools/perf_expectations/README @@ -0,0 +1 @@ +See https://sites.google.com/a/google.com/rtc-platform/engineering/managing-performance-expectations. \ No newline at end of file diff --git a/tools/perf_expectations/perf_expectations.json b/tools/perf_expectations/perf_expectations.json new file mode 100644 index 0000000000..fe520b0b65 --- /dev/null +++ b/tools/perf_expectations/perf_expectations.json @@ -0,0 +1,3 @@ +{"linux-large-tests/audio_e2e_test/audio_e2e_score/e2e_score": {"reva": 3268, "revb": 3329, "type": "absolute", "better": "higher", "improve": 4.6557, "regress": 3.83895, "sha1": "c10a1507"}, + "load": true +} diff --git a/tools/perf_expectations/webrtc_perf_expectations.cfg b/tools/perf_expectations/webrtc_perf_expectations.cfg new file mode 100644 index 0000000000..21944afbdc --- /dev/null +++ b/tools/perf_expectations/webrtc_perf_expectations.cfg @@ -0,0 +1,4 @@ +{ + "base_url": "http://www.corp.google.com/~webrtc-cb/perf/", + "perf_file": "perf_expectations.json" +}